1. 18 Nov, 2015 16 commits
    • Yorick Peterse's avatar
      Added Project.visible_to_user · 38a75f59809d
      Yorick Peterse authored
      This method can be used to filter projects to those visible to a given
      user.
      38a75f59809d
    • Yorick Peterse's avatar
      Group methods for filtering public/visible groups · ab8697eb09f7
      Yorick Peterse authored
      These methods will be used to get a list of groups, optionally
      restricted to only those visible to a given user.
      ab8697eb09f7
    • Yorick Peterse's avatar
      Added Event.limit_recent · 6febd50c7daf
      Yorick Peterse authored
      This will be used to move some querying logic from the users controller
      to the Event model (where it belongs).
      6febd50c7daf
    • Yorick Peterse's avatar
      Refactor ProjectsFinder to not pluck IDs · 1d2439555e72
      Yorick Peterse authored
      This class now uses a UNION (when needed) instead of plucking tens of
      thousands of project IDs into memory. The tests have also been
      re-written to ensure all different use cases are tested properly
      (assuming I didn't forget any cases).
      
      The finder has also been broken up into 3 different finder classes:
      
      * ContributedProjectsFinder: class for getting the projects a user
        contributed to.
      * PersonalProjectsFinder: class for getting the personal projects of a
        user.
      * ProjectsFinder: class for getting generic projects visible to a given
        user.
      
      Previously a lot of the logic of these finders was handled directly in
      the users controller.
      1d2439555e72
    • Yorick Peterse's avatar
      Refactoed GroupsFinder into two separate classes · 1df8b8dd724a
      Yorick Peterse authored
      In the previous setup the GroupsFinder class had two distinct tasks:
      
      1. Finding the projects user A could see
      2. Finding the projects of user A that user B could see
      
      Task two was actually handled outside of the GroupsFinder (in the
      UsersController) by restricting the returned list of groups to those the
      viewed user was a member of. Moving all this logic into a single finder
      proved to be far too complex and confusing, hence there are now two
      finders:
      
      * GroupsFinder: for finding groups a user can see
      * JoinedGroupsFinder: for finding groups that user A is a member of,
        restricted to either public groups or groups user B can also see.
      1df8b8dd724a
    • Yorick Peterse's avatar
      83a3349f88ce
    • Yorick Peterse's avatar
      Refactor getting user groups/projects/contributions · a34baae062db
      Yorick Peterse authored
      This new setup no longer loads any IDs into memory using "pluck",
      instead using SQL UNIONs to merge the various datasets together. This
      results in greatly improved query performance as well as a reduction of
      memory usage.
      
      The old setup was in particular problematic when requesting the
      authorized projects _including_ public/internal projects as this would
      result in roughly 65000 project IDs being loaded into memory. These IDs
      would in turn be passed to other queries.
      a34baae062db
    • Yorick Peterse's avatar
      Prefix table names for User UNIONs · a1eef3a1e81f
      Yorick Peterse authored
      a1eef3a1e81f
    • Yorick Peterse's avatar
      Use SQL::Union for User#authorized_groups · bcd70e14b018
      Yorick Peterse authored
      This removes the need for plucking any IDs into Ruby.
      bcd70e14b018
    • Yorick Peterse's avatar
      Make it easier to re-apply default sort orders · 04a18ea941d4
      Yorick Peterse authored
      By moving the default sort order into a separate scope (and calling this
      from the default scope) we can more easily re-apply a default order
      without having to specify the exact column/ordering all over the place.
      04a18ea941d4
    • Yorick Peterse's avatar
      Use SQL::Union for User#authorized_projects · be3fa25a7e69
      Yorick Peterse authored
      This allows retrieving of the list of authorized projects using a single
      query, without having to load any IDs into Ruby. This in turn also means
      we can remove the method User#authorized_projects_id.
      be3fa25a7e69
    • Yorick Peterse's avatar
      Added Gitlab::SQL::Union class · 951489821e97
      Yorick Peterse authored
      This class can be used to join multiple AcitveRecord::Relation objects
      together using a SQL UNION statement. ActiveRecord < 5.0 sadly doesn't
      support UNION and existing Gems out there don't handle prepared
      statements (e.g. they never incremented the variable bindings).
      951489821e97
    • Yorick Peterse's avatar
      Faster way of obtaining latest event update time · fe111b158e71
      Yorick Peterse authored
      Instead of using MAX(events.updated_at) we can simply sort the events in
      descending order by the "id" column and grab the first row. In other
      words, instead of this:
      
          SELECT max(events.updated_at) AS max_id
          FROM events
          LEFT OUTER JOIN projects   ON projects.id   = events.project_id
          LEFT OUTER JOIN namespaces ON namespaces.id = projects.namespace_id
          WHERE events.author_id IS NOT NULL
          AND events.project_id IN (13083);
      
      we can use this:
      
          SELECT events.updated_at AS max_id
          FROM events
          LEFT OUTER JOIN projects   ON projects.id   = events.project_id
          LEFT OUTER JOIN namespaces ON namespaces.id = projects.namespace_id
          WHERE events.author_id IS NOT NULL
          AND events.project_id IN (13083)
          ORDER BY events.id DESC
          LIMIT 1;
      
      This has the benefit that on PostgreSQL a backwards index scan can be
      used, which due to the "LIMIT 1" will at most process only a single row.
      This in turn greatly speeds up the process of grabbing the latest update
      time. This can be confirmed by looking at the query plans. The first
      query produces the following plan:
      
          Aggregate  (cost=43779.84..43779.85 rows=1 width=12) (actual time=2142.462..2142.462 rows=1 loops=1)
            ->  Index Scan using index_events_on_project_id on events  (cost=0.43..43704.69 rows=30060 width=12) (actual time=0.033..2138.086 rows=32769 loops=1)
                  Index Cond: (project_id = 13083)
                  Filter: (author_id IS NOT NULL)
          Planning time: 1.248 ms
          Execution time: 2142.548 ms
      
      The second query in turn produces the following plan:
      
          Limit  (cost=0.43..41.65 rows=1 width=16) (actual time=1.394..1.394 rows=1 loops=1)
            ->  Index Scan Backward using events_pkey on events  (cost=0.43..1238907.96 rows=30060 width=16) (actual time=1.394..1.394 rows=1 loops=1)
                  Filter: ((author_id IS NOT NULL) AND (project_id = 13083))
                  Rows Removed by Filter: 2104
          Planning time: 0.166 ms
          Execution time: 1.408 ms
      
      According to the above plans the 2nd query is around 1500 times faster.
      However, re-running the first query produces timings of around 80 ms,
      making the 2nd query "only" around 55 times faster.
      fe111b158e71
    • Job van der Voort's avatar
      Merge branch 'add_lfs_doc' into 'master' · c50243b64312
      Job van der Voort authored
      Documentation for Git LFS
      
      Doc explaining how to use Git LFS, how to use Git LFS with GitLab, known issues and troubleshooting tips.
      
      See merge request !1813
      c50243b64312
    • Job van der Voort's avatar
      missing . · 97e19cbceedd
      Job van der Voort authored
      97e19cbceedd
    • Marin Jankovski's avatar
      Updates to the lfs doc. · a1937dcf5715
      Marin Jankovski authored
      a1937dcf5715
  2. 17 Nov, 2015 24 commits