1. 07 Jan, 2019 1 commit
    • Steve Azzopardi's avatar
      Refactor project.latest_successful_builds_for def · 50a1dd6a79ff
      Steve Azzopardi authored
      `project.latest_successful_builds_for(ref)` is being used to find a
      single job all the time. This results into us having to call `find_by`
      inside of the controller which violates our CodeReuse/ActiveRecord
      rubocop rule.
      
      Refactor `project.latest_successful_builds_for(ref)` to
      `project.latest_successful_build_for(job_name, ref)` which will execute
      the `find_by` inside of the model.
      
      Also create `project.latest_successful_build_for!(job_name, ref)` which
      raises an exception instead of returning nil.
      50a1dd6a79ff
  2. 16 Oct, 2018 1 commit
  3. 26 Sep, 2018 1 commit
    • gfyoung's avatar
      Enable even more frozen string in app/controllers · 73f4d7f633c9
      gfyoung authored
      Enables frozen string for some vestigial files as
      well as the following:
      
      * app/controllers/projects/**/*.rb
      * app/controllers/sherlock/**/*.rb
      * app/controllers/snippets/**/*.rb
      * app/controllers/users/**/*.rb
      
      Partially addresses #47424.
      73f4d7f633c9
  4. 11 Sep, 2018 1 commit
  5. 05 Jul, 2017 1 commit
  6. 24 May, 2017 1 commit
  7. 23 May, 2017 1 commit