- 20 Mar, 2017 10 commits
-
-
Rémy Coutable authored
New Gitlab::UrlSanitizer.http_credentials_for_user method responsible for generating a credentials hash from a user. Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Dongqing Hu authored
-
George Andrinopoulos authored
-
Jarka Kadlecova authored
-
Tomasz Maczukin authored
-
Tomasz Maczukin authored
In APIv1 we've been sending all jobs from previous stages and a `dependencies` list with names of jobs that user want to download artifacts from. This was selected on Runners side. In APIv1 we've planned to send only jobs that were defined (if any; and all previous jobs by default). However I've missed the fact that it was Runner who selected jobs, not GitLab. And now current version of APIV4 sends all jobs everytime. This commit fixes this. If user will define `dependencies` in his job, then GitLab will send only selected jobs.
-
Tomasz Maczukin authored
Artifacts download for authorization is using a job token of job to which the artifact belongs. In APIv1 the token was sent with dependent jobs details and in APIv4 it was designed to also contain it. However I forgot about this parameter while working on `/api/v4/jobs/request` endpoint. This commit adds a missing parameter which is required for APIv4 to work properly.
-
Tomasz Maczukin authored
In Runner v1.3.0 we've started to send User-Agent header with Runner's version data. Since GitLab v8.12.0 we've started to use this header to check if used Runner's version supports 204 status code instead of 404 as a response when there is no jobs to execute by a Runner. In APIv4 (introduced in GitLab 9.0.0) will require Runner v9.0.0. And writing more accurately: GitLab Runner v9.0.0 will require GitLab at least 9.0.0. Because of such breaking change we are able to switch entirely to 204 response code and there is no need to do check of User-Agent. This commit removes useless code and complexity.
-
Tomasz Maczukin authored
In APIv1 we were using UpdateJob to verify if the runner exists. It was the only method that was using Runner's token and used in special way had no side effects (like scheduling a new job or unregisterring a Runner). In APIv4 we've change UpdateJob to use job's token as authentication credentials, and that way we've removed the only endpoint that could be used to verify if the Runner with a certain token exists in target GitLab installation. This commit adds `POST /api/v4/runners/verify` endpoint whose only responsibility is to respond if Runner with posted credentials exists or not.
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 17 Mar, 2017 12 commits
-
-
Kamil Trzciński authored
-
Dongqing Hu authored
-
Filipa Lacerda authored
-
Yorick Peterse authored
This returns the ActiveRecord configuration for the current environment. While CE doesn't use this very often, EE will use it in a few places for the database load balancing code. I'm adding this to CE so we don't end up with merge conflicts in this file.
-
Adam Niedzielski authored
Closes #28890
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Alex Sanford authored
-
Luke "Jared" Bennett authored
-
Rémy Coutable authored
This solves transient failures when a text contains HTML-escapable characters such as `'`. Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Lin Jen-Shin authored
Hopefully this could fix: https://gitlab.com/gitlab-org/gitlab-ce/builds/12431186 To make sure that the email would never contain "joh" otherwise it would match to this `another_user`.
-
Lin Jen-Shin authored
days. This shall fix: https://gitlab.com/gitlab-org/gitlab-ce/builds/12411626 and other test failures for the same thing.
-
Oswaldo Ferreira authored
-
- 16 Mar, 2017 18 commits
-
-
-
Mike Greiling authored
-
Tiago Botelho authored
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Mark Fletcher authored
-
Phil Hughes authored
-
Jarka Kadlecova authored
-
Phil Hughes authored
-
Phil Hughes authored
-
Rémy Coutable authored
Gitlab::Emoji#gl_emoji_tag now returns early instead of raising a 500 error. Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Toon Claes authored
To get the issues that have no label, the special keyword `No Label` can be used. This `No Label` label can be used like any other label.
-
Phil Hughes authored
Previously if the project had more than 100 branches or tags it wouldnt display them even after searching. This now correctly sends an AJAx request to the backend to search for the branches/tags Closes #29545
-
Michael authored
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
This could happen when the repository is missing. In which case cache needs to be cleared
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
This reads status from redis & stores it in redis if it was missing. If the project has no HEAD, the cache is deleted
-