Read about our upcoming Code of Conduct on this issue

  1. 04 Feb, 2020 1 commit
  2. 03 Oct, 2019 1 commit
  3. 30 Sep, 2019 1 commit
  4. 02 Apr, 2019 1 commit
    • Igor's avatar
      Backport splitting approval changes from CE · 8ab258e47784
      Igor authored
      Author and committers approvals are split in EE
      This commit provides backports for those changes
      
      This reverts commit 886f00bcba23d67e2c86591c2eb5359ef457a2f9.
      8ab258e47784
  5. 21 Mar, 2019 3 commits
    • Luke Duncalfe's avatar
      Handle blank projects in CommitCollection#enrich! · 4afeae40e9be
      Luke Duncalfe authored
      A project is needed in order to fetch data from gitaly. Projects can be
      absent from commits in certain rare situations (like when viewing a MR
      of a deleted fork). In these cases, assume that the enriched data is not
      needed.
      
      See this comment:
      
      https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26144#note_152191106
      
      "It's led to a dilemma about where to "fix" this in code. I'm going
      to fix it by allowing CommitCollection#enrich! to just return unenriched
      commits when a project is missing, essentially "silently failing". I
      hope this is the right decision. It's going with the assumption that
      calls in these situations in the future are not needing the full data.
      The alternative would be to allow CommitCollection#enrich! to still
      error, but handle it in the methods that call #enrich!, however that
      might lead to brittleness in future when working with project-less MRs."
      4afeae40e9be
    • Luke Duncalfe's avatar
      Enrich commits with full data in CommitCollection · abd2ee50323c
      Luke Duncalfe authored
      Allow incomplete commit records to load their full data from gitaly.
      
      Commits can be based on a Hash of data retrieved from PostgreSQL, and
      this data can be intentionally incomplete in order to save space.
      
      A new method #gitaly? has been added to Gitlab::Git::Commit, which
      returns true if the underlying data source of the Commit is a
      Gitaly::GitCommit.
      
      CommitCollection now has a method #enrich which replaces non-gitaly
      commits in place with commits from gitaly.
      
      CommitCollection#without_merge_commits has been updated to call this
      method, as in order to determine a merge commit we need to have parent
      data.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/58805
      abd2ee50323c
    • Sean McGivern's avatar
      Revert "Merge branch... · 9ba9fc06dccc
      Sean McGivern authored
      Revert "Merge branch '58805-allow-incomplete-commit-data-to-be-fetched-from-collection' into 'master'"
      
      This reverts merge request !26144
      9ba9fc06dccc
  6. 20 Mar, 2019 1 commit
    • Luke Duncalfe's avatar
      Handle blank projects in CommitCollection#enrich! · b7efee913973
      Luke Duncalfe authored
      A project is needed in order to fetch data from gitaly. Projects can be
      absent from commits in certain rare situations (like when viewing a MR
      of a deleted fork). In these cases, assume that the enriched data is not
      needed.
      
      See this comment:
      
      https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26144#note_152191106
      
      "It's led to a dilemma about where to "fix" this in code. I'm going
      to fix it by allowing CommitCollection#enrich! to just return unenriched
      commits when a project is missing, essentially "silently failing". I
      hope this is the right decision. It's going with the assumption that
      calls in these situations in the future are not needing the full data.
      The alternative would be to allow CommitCollection#enrich! to still
      error, but handle it in the methods that call #enrich!, however that
      might lead to brittleness in future when working with project-less MRs."
      b7efee913973
  7. 18 Mar, 2019 1 commit
    • Luke Duncalfe's avatar
      Enrich commits with full data in CommitCollection · 47d1456440c9
      Luke Duncalfe authored
      Allow incomplete commit records to load their full data from gitaly.
      
      Commits can be based on a Hash of data retrieved from PostgreSQL, and
      this data can be intentionally incomplete in order to save space.
      
      A new method #gitaly? has been added to Gitlab::Git::Commit, which
      returns true if the underlying data source of the Commit is a
      Gitaly::GitCommit.
      
      CommitCollection now has a method #enrich which replaces non-gitaly
      commits in place with commits from gitaly.
      
      CommitCollection#without_merge_commits has been updated to call this
      method, as in order to determine a merge commit we need to have parent
      data.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/58805
      47d1456440c9
  8. 15 Feb, 2019 1 commit
  9. 06 Feb, 2019 1 commit
  10. 07 Jan, 2019 1 commit
  11. 05 Dec, 2018 1 commit
  12. 16 Nov, 2017 1 commit