- 19 Jan, 2021 15 commits
-
-
Georges Racinet authored
Now that the model is using the Heptapod specific method, the mocking test had to be adapted as well --HG-- branch : heptapod
-
Georges Racinet authored
and updated the timings with the first successful run of these. --HG-- branch : heptapod
-
Georges Racinet authored
In particular, we're fixing the RSpec tests for the services API: they were failing because the `readthedocs` service is disable for the (Git) project provided by the fixture. Part of #397 --HG-- branch : heptapod
-
Georges Racinet authored
IIRC, it's possible that GitLab accepts a handful of failing tests UPSTREAM --HG-- branch : heptapod
-
Georges Racinet authored
--HG-- branch : heptapod
-
Georges Racinet authored
--HG-- branch : heptapod
-
Georges Racinet authored
Of course it'd be better to have a real test for them, on a Mercurial repo. --HG-- branch : heptapod
-
Georges Racinet authored
Also, these are important enough to be part of the regular RSpec scope. --HG-- branch : heptapod
-
Georges Racinet authored
GitLab now has a dedicated method instead of this `|| 'master'` spotted because I thought it would be enough to fix #409 (it isn't). UPSTREAM if not already fixed --HG-- branch : heptapod
-
Georges Racinet authored
Tracking issue for the Mercurial case is #409 --HG-- branch : heptapod
-
Georges Racinet authored
Heptapod has specific logic so that it is more obvious to users that can't create projects in their personal namespace that they may still do it in a Group. But at least in current GitLab, such checks are done at lower level than the service, namely in the model. So we need to use our specific check (calling specific method) there. This was spotted by the test in `spec/requests/api/projects.rb` because our `deny_namespace!` ended up in the API in a 400 error (message: "invalid namespace") instead of the expeted 403 with explicit message about the limit --HG-- branch : heptapod
-
Georges Racinet authored
This makes it a quasi-inverse of PUT. Closes #301 --HG-- branch : heptapod
-
Georges Racinet authored
This is better for maintainability --HG-- branch : heptapod
-
Georges Racinet authored
Another demonstration why integration tests are useful. --HG-- branch : heptapod
-
Georges Racinet authored
This will be needed when we parse back values in `#get_hgrc`. - item names have dashes, not underscores - using two different item types --HG-- branch : heptapod
-
- 18 Jan, 2021 9 commits
-
-
Georges Racinet authored
--HG-- branch : heptapod
-
Georges Racinet authored
Done on the same homogeneous pool of servers as precedently for models and services. --HG-- branch : heptapod
-
Georges Racinet authored
Should also make sense UPSTREAM --HG-- branch : heptapod
-
Georges Racinet authored
These will part of the run for release branches. --HG-- branch : heptapod
-
Georges Racinet authored
This additional argument is obviously meant for Mercurial. It is ignored for Git projects but still needs to be there. This one is important (and modified) enough to be in the regular scope. --HG-- branch : heptapod
-
Georges Racinet authored
--HG-- branch : heptapod
-
Georges Racinet authored
--HG-- branch : heptapod
-
Georges Racinet authored
--HG-- branch : heptapod
-
Georges Racinet authored
Same as was done previously for `#rm_namespace`, this is just to ignore it. But this has to be systematic, because `GitlabShellWorker` is generic and will pass it in all cases. --HG-- branch : heptapod
-
- 17 Jan, 2021 8 commits
-
-
Georges Racinet authored
This was just giving warnings, but we can as well get rid of them. --HG-- branch : heptapod
-
Georges Racinet authored
See #402 for explanations (for now this is just upstream version) --HG-- branch : heptapod
-
Georges Racinet authored
Of course, if the administrator chose not to allow Git repos, Git-only options must not be displayed. --HG-- branch : heptapod
-
Georges Racinet authored
GitLab has several builtin import features, that were masked because Heptapod only support Git. All that was needed is introspection of the import type in the CreateService, so that we can set `vcs_type` to `git` instead of the default (currently `hg_git`). Closes #398 --HG-- branch : heptapod
-
Georges Racinet authored
Closes #405 Works right away for Mercurial repositories. --HG-- branch : heptapod
-
Georges Racinet authored
Notably, on the waiting page, the pseudo-displayed command is now the appropriate one for the chosen VCS type. We didn't bother giving Git equivalents for the incremental push strategy hints for big repos, feeling it was enough to underline that the example is for Mercurial, letting people think of appropriate ways of doing with Git. --HG-- branch : heptapod
-
Georges Racinet authored
Closes #399 The worker wasn't called any more, since fdb960fc35b5 --HG-- branch : heptapod
-
Georges Racinet authored
These were taken on a homogenous set of workers, The number of RSpec files goes up to 2492 from 1280. --HG-- branch : heptapod
-
- 16 Jan, 2021 2 commits
-
-
Georges Racinet authored
--HG-- branch : heptapod
-
Georges Racinet authored
--HG-- branch : heptapod
-
- 17 Jan, 2021 1 commit
-
-
Georges Racinet authored
Reverting to what the RSpec test expects. Actually that Git-centric wording was introduced at a time there were two calls (all projects being hg_git by then), the other one having the corresponding Mercurial message. Now everything is handled by passing a `vcs_type` parameter to the lower layers. --HG-- branch : heptapod
-
- 16 Jan, 2021 5 commits
-
-
Georges Racinet authored
In 506baec55008, we changed the behaviour back to sending with an explicit To: in the case there's only one recipient. This fixes the related tests, that we weren't running yet by that time. UPSTREAM (together with 506baec55008) --HG-- branch : heptapod
-
Georges Racinet authored
This will be useful to adapt tests for 506baec55008 UPSTREAM --HG-- branch : heptapod
-
Georges Racinet authored
This test was failing for me in GDK context because it assumes that design management to be disabled. UPSTREAM --HG-- branch : heptapod
-
Georges Racinet authored
This is is the same as what happened in RSpec tests for `Repository::Destroyservice` --HG-- branch : heptapod
-
Georges Racinet authored
This was a hard error for empty Git repositories, because of one missing `&&`. This also motivates adding the RSpec tests for this model to the regular scope --HG-- branch : heptapod
-