1. 28 Nov, 2017 3 commits
  2. 24 Nov, 2017 1 commit
  3. 23 Nov, 2017 1 commit
  4. 15 Nov, 2017 1 commit
  5. 09 Nov, 2017 1 commit
  6. 07 Nov, 2017 1 commit
    • Yorick Peterse's avatar
      Rewrite the GitHub importer from scratch · 86c05c535691
      Yorick Peterse authored
      Prior to this MR there were two GitHub related importers:
      
      * Github::Import: the main importer used for GitHub projects
      * Gitlab::GithubImport: importer that's somewhat confusingly used for
        importing Gitea projects (apparently they have a compatible API)
      
      This MR renames the Gitea importer to Gitlab::LegacyGithubImport and
      introduces a new GitHub importer in the Gitlab::GithubImport namespace.
      This new GitHub importer uses Sidekiq for importing multiple resources
      in parallel, though it also has the ability to import data sequentially
      should this be necessary.
      
      The new code is spread across the following directories:
      
      * lib/gitlab/github_import: this directory contains most of the importer
        code such as the classes used for importing resources.
      * app/workers/gitlab/github_import: this directory contains the Sidekiq
        workers, most of which simply use the code from the directory above.
      * app/workers/concerns/gitlab/github_import: this directory provides a
        few modules that are included in every GitHub importer worker.
      
      == Stages
      
      The import work is divided into separate stages, with each stage
      importing a specific set of data. Stages will schedule the work that
      needs to be performed, followed by scheduling a job for the
      "AdvanceStageWorker" worker. This worker will periodically check if all
      work is completed and schedule the next stage if this is the case. If
      work is not yet completed this worker will reschedule itself.
      
      Using this approach we don't have to block threads by calling `sleep()`,
      as doing so for large projects could block the thread from doing any
      work for many hours.
      
      == Retrying Work
      
      Workers will reschedule themselves whenever necessary. For example,
      hitting the GitHub API's rate limit will result in jobs rescheduling
      themselves. These jobs are not processed until the rate limit has been
      reset.
      
      == User Lookups
      
      Part of the importing process involves looking up user details in the
      GitHub API so we can map them to GitLab users. The old importer used
      an in-memory cache, but this obviously doesn't work when the work is
      spread across different threads.
      
      The new importer uses a Redis cache and makes sure we only perform
      API/database calls if absolutely necessary.  Frequently used keys are
      refreshed, and lookup misses are also cached; removing the need for
      performing API/database calls if we know we don't have the data we're
      looking for.
      
      == Performance & Models
      
      The new importer in various places uses raw INSERT statements (as
      generated by `Gitlab::Database.bulk_insert`) instead of using Rails
      models. This allows us to bypass any validations and callbacks,
      drastically reducing the number of SQL queries and Gitaly RPC calls
      necessary to import projects.
      
      To ensure the code produces valid data the corresponding tests check if
      the produced rows are valid according to the model validation rules.
      86c05c535691
  7. 06 Nov, 2017 2 commits
  8. 04 Nov, 2017 1 commit
  9. 03 Nov, 2017 2 commits
  10. 02 Nov, 2017 1 commit
  11. 31 Oct, 2017 2 commits
  12. 30 Oct, 2017 1 commit
  13. 27 Oct, 2017 2 commits
    • Gabriel Mazetto's avatar
      Moved renaming operations to storage layer abstraction · 190b9c22851e
      Gabriel Mazetto authored
      When project storage_version is `2` means attachments are using
      hashed storage.
      190b9c22851e
    • Zeger-Jan van de Weg's avatar
      Cache commits on the repository model · 77de64bc4589
      Zeger-Jan van de Weg authored
      Now, when requesting a commit from the Repository model, the results are
      not cached. This means we're fetching the same commit by oid multiple times
      during the same request. To prevent us from doing this, we now cache
      results. Caching is done only based on object id (aka SHA).
      
      Given we cache on the Repository model, results are scoped to the
      associated project, eventhough the change of two repositories having the
      same oids for different commits is small.
      77de64bc4589
  14. 23 Oct, 2017 2 commits
  15. 17 Oct, 2017 1 commit
    • Bob Van Landuyt's avatar
      Fix errors when deleting a forked project · 192615692153
      Bob Van Landuyt authored
      The problem would occur when the `ForkedProjectLink` was deleted, but
      the `ForkNetworkMember` was not. The delete would be rolled back and
      retried.
      
      But the error would not be saved because `Project#forked?`
      would still be true, because the `ForkNetworkMember` exists. But the
      `Project#forked_project_link` would be `nil`. So the validation for
      the visibility level would fail.
      192615692153
  16. 13 Oct, 2017 1 commit
  17. 10 Oct, 2017 1 commit
  18. 07 Oct, 2017 3 commits
  19. 06 Oct, 2017 1 commit
    • Toon Claes's avatar
      Create idea of read-only database · a867cd2b92f4
      Toon Claes authored
      In GitLab EE, a GitLab instance can be read-only (e.g. when it's a Geo
      secondary node). But in GitLab CE it also might be useful to have the
      "read-only" idea around. So port it back to GitLab CE.
      
      Also having the principle of read-only in GitLab CE would hopefully
      lead to less errors introduced, doing write operations when there
      aren't allowed for read-only calls.
      
      Closes gitlab-org/gitlab-ce#37534.
      a867cd2b92f4
  20. 05 Oct, 2017 3 commits
  21. 04 Oct, 2017 4 commits
  22. 02 Oct, 2017 3 commits
  23. 29 Sep, 2017 2 commits