Read about our upcoming Code of Conduct on this issue

  1. 06 Jul, 2018 1 commit
  2. 12 Jun, 2018 1 commit
  3. 07 May, 2018 3 commits
  4. 04 May, 2018 1 commit
  5. 03 May, 2018 2 commits
  6. 30 Apr, 2018 1 commit
  7. 25 Apr, 2018 1 commit
  8. 24 Apr, 2018 1 commit
  9. 23 Apr, 2018 2 commits
  10. 28 Feb, 2018 2 commits
  11. 07 Feb, 2018 2 commits
  12. 05 Feb, 2018 1 commit
  13. 01 Feb, 2018 1 commit
  14. 30 Jan, 2018 1 commit
  15. 14 Dec, 2017 1 commit
  16. 06 Oct, 2017 1 commit
    • Toon Claes's avatar
      Create idea of read-only database · a867cd2b92f4
      Toon Claes authored
      In GitLab EE, a GitLab instance can be read-only (e.g. when it's a Geo
      secondary node). But in GitLab CE it also might be useful to have the
      "read-only" idea around. So port it back to GitLab CE.
      Also having the principle of read-only in GitLab CE would hopefully
      lead to less errors introduced, doing write operations when there
      aren't allowed for read-only calls.
      Closes gitlab-org/gitlab-ce#37534.
  17. 28 Sep, 2017 2 commits
  18. 25 Aug, 2017 1 commit
  19. 22 Aug, 2017 2 commits
  20. 10 Aug, 2017 1 commit
  21. 04 Aug, 2017 1 commit
  22. 02 Aug, 2017 2 commits
  23. 01 Aug, 2017 1 commit
  24. 27 Jul, 2017 1 commit
  25. 30 Jun, 2017 1 commit
  26. 21 Jun, 2017 1 commit
  27. 05 Jun, 2017 1 commit
  28. 02 Jun, 2017 1 commit
  29. 18 May, 2017 2 commits
  30. 17 May, 2017 1 commit
    • Yorick Peterse's avatar
      Use CTEs for nested groups and authorizations · f63dad32f25f
      Yorick Peterse authored
      This commit introduces the usage of Common Table Expressions (CTEs) to
      efficiently retrieve nested group hierarchies, without having to rely on
      the "routes" table (which is an _incredibly_ inefficient way of getting
      the data). This requires a patch to ActiveRecord (found in the added
      initializer) to work properly as ActiveRecord doesn't support WITH
      statements properly out of the box.
      Unfortunately MySQL provides no efficient way of getting nested groups.
      For example, the old routes setup could easily take 5-10 seconds
      depending on the amount of "routes" in a database. Providing vastly
      different logic for both MySQL and PostgreSQL will negatively impact the
      development process. Because of this the various nested groups related
      methods return empty relations when used in combination with MySQL.
      For project authorizations the logic is split up into two classes:
      * Gitlab::ProjectAuthorizations::WithNestedGroups
      * Gitlab::ProjectAuthorizations::WithoutNestedGroups
      Both classes get the fresh project authorizations (= as they should be
      in the "project_authorizations" table), including nested groups if
      PostgreSQL is used. The logic of these two classes is quite different
      apart from their public interface. This complicates development a bit,
      but unfortunately there is no way around this.
      This commit also introduces Gitlab::GroupHierarchy. This class can be
      used to get the ancestors and descendants of a base relation, or both by
      using a UNION. This in turn is used by methods such as:
      * Namespace#ancestors
      * Namespace#descendants
      * User#all_expanded_groups
      Again this class relies on CTEs and thus only works on PostgreSQL. The
      Namespace methods will return an empty relation when MySQL is used,
      while User#all_expanded_groups will return only the groups a user is a
      direct member of.
      Performance wise the impact is quite large. For example, on
      Namespace#descendants used to take around 580 ms to retrieve data for a
      particular user. Using CTEs we are able to reduce this down to roughly 1
      millisecond, returning the exact same data.
      == On The Fly Refreshing
      Refreshing of authorizations on the fly (= when
      users.authorized_projects_populated was not set) is removed with this
      commit. This simplifies the code, and ensures any queries used for
      authorizations are not mutated because they are executed in a Rails
      scope (e.g. Project.visible_to_user).
      This commit includes a migration to schedule refreshing authorizations
      for all users, ensuring all of them have their authorizations in place.
      Said migration schedules users in batches of 5000, with 5 minutes
      between every batch to smear the load around a bit.
      == Spec Changes
      This commit also introduces some changes to various specs. For example,
      some specs for ProjectTeam assumed that creating a personal project
      would _not_ lead to the owner having access, which is incorrect. Because
      we also no longer refresh authorizations on the fly for new users some
      code had to be added to the "empty_project" factory. This chunk of code
      ensures that the owner's permissions are refreshed after creating the
      project, something that is normally done in Projects::CreateService.