Read about our upcoming Code of Conduct on this issue

  1. 11 Oct, 2016 3 commits
  2. 10 Oct, 2016 3 commits
    • Stan Hu's avatar
      Fix Error 500 when viewing old merge requests with bad diff data · 9b9d9122f620
      Stan Hu authored
      Customers running old versions of GitLab may have MergeRequestDiffs with
      the text ["--broken diff"] due to text generated by gitlab_git 1.0.3.
      To avoid the Error 500, verify that each element is a type that gitlab_git
      will accept before attempting to create a DiffCollection.
      
      Closes #20776
      9b9d9122f620
    • Yorick Peterse's avatar
      Precalculate trending projects · 8d729570767c
      Yorick Peterse authored
      This commit introduces a Sidekiq worker that precalculates the list of
      trending projects on a daily basis. The resulting set is stored in a
      database table that is then queried by Project.trending.
      
      This setup means that Unicorn workers no longer _may_ have to calculate
      the list of trending projects. Furthermore it supports filtering without
      any complex caching mechanisms.
      
      The data in the "trending_projects" table is inserted in the same order
      as the project ranking. This means that getting the projects in the
      correct order is simply a matter of:
      
          SELECT projects.*
          FROM projects
          INNER JOIN trending_projects ON trending_projects.project_id = projects.id
          ORDER BY trending_projects.id ASC;
      
      Such a query will only take a few milliseconds at most (as measured on
      GitLab.com), opposed to a few seconds for the query used for calculating
      the project ranks.
      
      The migration in this commit does not require downtime and takes care of
      populating an initial list of trending projects.
      8d729570767c
    • Adam Niedzielski's avatar
      Make searching for commits case insensitive. · 6a19e1b1e064
      Adam Niedzielski authored
      Fixes #21800.
      6a19e1b1e064
  3. 08 Oct, 2016 3 commits
  4. 07 Oct, 2016 6 commits
  5. 06 Oct, 2016 1 commit
  6. 05 Oct, 2016 3 commits
    • Marc Siegfriedt's avatar
      multi-file commit · e5bf8f5f5bd7
      Marc Siegfriedt authored
      add docs and tests - add additional validation
      allow move without content
      updated response
      e5bf8f5f5bd7
    • Yorick Peterse's avatar
      Refactor Gitlab::Identifier · f22b88d412ae
      Yorick Peterse authored
      This refactors Gitlab::Identifier so it uses fewer queries and is
      actually tested. Queries are reduced by caching the output as well as
      using 1 query (instead of 2) to find a user using an SSH key.
      f22b88d412ae
    • Stan Hu's avatar
      Fix project deletion when feature visibility is set to private · 0a4f2b010c68
      Stan Hu authored
      Projects that are destroyed are put in the pending_delete state.
      The ProjectDestroyWorker checks whether the current user has
      access, but since the ProjectFeature class uses the default scope
      of the Project, it will not be able to find the right project.
      
      This was a regression in 8.12 that caused the following stack trace:
      
      ```
      NoMethodError: undefined method `team' for nil:NilClass
        from app/models/project_feature.rb:62:in `get_permission'
        from app/models/project_feature.rb:34:in `feature_available?'
        from app/models/project.rb:21:in `feature_available?'
        from app/policies/project_policy.rb:170:in `disabled_features!'
        from app/policies/project_policy.rb:29:in `rules'
        from app/policies/base_policy.rb:82:in `block in abilities'
        from app/policies/base_policy.rb:113:in `collect_rules'
        from app/policies/base_policy.rb:82:in `abilities'
        from app/policies/base_policy.rb:50:in `abilities'
        from app/models/ability.rb:64:in `uncached_allowed'
        from app/models/ability.rb:58:in `allowed'
        from app/models/ability.rb:49:in `allowed?'
        from app/services/base_service.rb:11:in `can?'
        from lib/gitlab/metrics/instrumentation.rb:155:in `block in can?'
        from lib/gitlab/metrics/method_call.rb:23:in `measure'
        from lib/gitlab/metrics/instrumentation.rb:155:in `can?'
        from app/services/projects/destroy_service.rb:18:in `execute'
      ```
      
      Closes #22948
      0a4f2b010c68
  7. 04 Oct, 2016 15 commits
  8. 03 Oct, 2016 6 commits