Read about our upcoming Code of Conduct on this issue

  1. 20 Feb, 2018 1 commit
  2. 05 Jan, 2018 1 commit
  3. 05 Jul, 2017 1 commit
  4. 08 May, 2017 1 commit
  5. 06 Apr, 2017 1 commit
  6. 03 Apr, 2017 1 commit
  7. 19 Jul, 2016 1 commit
  8. 18 Jul, 2016 1 commit
  9. 13 Jul, 2016 2 commits
    • Robert Speicher's avatar
      Revert "Merge branch '18193-developers-can-merge' into 'master' · df7fb9e8d12f
      Robert Speicher authored
      This reverts commit 72baf9a18669, reversing
      changes made to cf491007802b.
      df7fb9e8d12f
    • Timothy Andrew's avatar
      Refactor `Gitlab::GitAccess` · a0fe55c0e0b9
      Timothy Andrew authored
      1. Don't use case statements for dispatch anymore. This leads to a lot
         of duplication, and makes the logic harder to follow.
      
      2. Remove duplicated logic.
      
          - For example, the `can_push_to_branch?` exists, but we also have a
            different way of checking the same condition within `change_access_check`.
      
          - This kind of duplication is removed, and the `can_push_to_branch?`
            method is used in both places.
      
      3. Move checks returning true/false to `UserAccess`.
      
          - All public methods in `GitAccess` now return an instance of
            `GitAccessStatus`. Previously, some methods would return
            true/false as well, which was confusing.
      
          - It makes sense for these kinds of checks to be at the level of a
            user, so the `UserAccess` class was repurposed for this. The prior
            `UserAccess.allowed?` classmethod is converted into an instance
            method.
      
          - All external uses of these checks have been migrated to use the
            `UserAccess` class
      
      4. Move the "change_access_check" into a separate class.
      
          - Create the `GitAccess::ChangeAccessCheck` class to run these
            checks, which are quite substantial.
      
          - `ChangeAccessCheck` returns an instance of `GitAccessStatus` as
            well.
      
      5. Break out the boolean logic in `ChangeAccessCheck` into `if/else`
         chains - this seems more readable.
      
      6. I can understand that this might look like overkill for !4892, but I
         think this is a good opportunity to clean it up.
      
          - http://martinfowler.com/bliki/OpportunisticRefactoring.html
      a0fe55c0e0b9
  10. 05 Jul, 2016 3 commits
  11. 20 Jun, 2016 1 commit
  12. 16 Jun, 2016 2 commits
  13. 13 Jun, 2016 1 commit
  14. 08 Dec, 2015 1 commit
  15. 09 Sep, 2015 1 commit
  16. 26 Aug, 2015 1 commit
  17. 24 Mar, 2015 1 commit
  18. 21 Jan, 2015 1 commit
  19. 02 Jun, 2014 1 commit
  20. 22 May, 2014 1 commit