- 06 Sep, 2017 1 commit
-
-
Ashley Dumaine authored
-
- 04 Sep, 2017 5 commits
-
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
- 16 Aug, 2017 1 commit
-
-
Zeger-Jan van de Weg authored
Main feature was the deprication of the Hashie stuff, so the access by calling keys as method is gone now.
-
- 14 Aug, 2017 2 commits
-
-
Robert Speicher authored
An upcoming update to rubocop-gitlab-security added additional violations.
-
Yorick Peterse authored
The number of forks of a project doesn't change very frequently and running a COUNT(*) every time this information is requested can be quite expensive. We also end up running such a COUNT(*) query at least twice on the homepage of a project. By caching this data and refreshing it when necessary we can reduce project homepage loading times by around 60 milliseconds (based on the timings of https://gitlab.com/gitlab-org/gitlab-ce).
-
- 10 Aug, 2017 1 commit
-
-
Yorick Peterse authored
This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
-
- 09 Aug, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 03 Aug, 2017 1 commit
-
-
Toon Claes authored
TodoService should not call `.select(&:id)` on todos, because this is bad performance. So instead use sub-queries, which will result in a single SQL query to the database. https://docs.gitlab.com/ee/development/sql.html#plucking-ids
-
- 28 Jul, 2017 1 commit
-
-
Richard Clamp authored
-
- 25 Jul, 2017 1 commit
-
-
Oswaldo Ferreira authored
-
- 20 Jul, 2017 1 commit
-
-
Lin Jen-Shin authored
-
- 19 Jul, 2017 1 commit
-
-
Lin Jen-Shin authored
-
- 13 Jul, 2017 1 commit
-
-
Robin Bobbitt authored
When sign-in is disabled: - skip password expiration checks - prevent password reset requests - don’t show Password tab in User Settings - don’t allow login with username/password for Git over HTTP requests - render 404 on requests to Profiles::PasswordsController
-
- 28 Jun, 2017 1 commit
-
-
Timothy Andrew authored
- Declaring an endpoint's scopes in a `before` block has proved to be unreliable. For example, if we're accessing the `API::Users` endpoint - code in a `before` block in `API::API` wouldn't be able to see the scopes set in `API::Users` since the `API::API` `before` block runs first. - This commit moves these declarations to the class level, since they don't need to change once set.
-
- 21 Jun, 2017 2 commits
-
-
vanadium23 authored
-
Grzegorz Bizon authored
-
- 15 Jun, 2017 1 commit
-
-
Eric Eastwood authored
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070 Deprecate "chat commands" in favor of "slash commands" We looked for things like: - `slash commmand` - `slash_command` - `slash-command` - `SlashCommand`
-
- 07 Jun, 2017 1 commit
-
-
Douwe Maan authored
-
- 06 Jun, 2017 1 commit
-
-
Lin Jen-Shin authored
-
- 02 Jun, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 01 Jun, 2017 2 commits
-
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
- 31 May, 2017 1 commit
-
-
Douwe Maan authored
-
- 30 May, 2017 2 commits
-
-
Toon Claes authored
To avoid the use of slow queries, remove some deprecated methods and encourage the use of ProjectFinder to find projects.
-
Toon Claes authored
The helper will be modified in V4, so copy the original to V4 to keep the current behavior in V3.
-
- 29 May, 2017 1 commit
-
-
Douwe Maan authored
-
- 24 May, 2017 3 commits
-
-
Douwe Maan authored
This reverts commit f0fc11a523e8
-
Douwe Maan authored
-
Douwe Maan authored
-
- 22 May, 2017 1 commit
-
-
Richard Clamp authored
The v3 API documentation claims that `can_push` is supported when adding a deploy_key. https://gitlab.com/gitlab-org/gitlab-ce/blob/8-16-stable/doc/api/deploy_keys.md#add-deploy-key Here we make good on this promise by adding `can_push` as an optional parameter so grape can route it. This was copied from the v4 API.
-
- 17 May, 2017 1 commit
-
-
Yorick Peterse authored
This hides/disables some UI elements and API parameters related to nested groups when MySQL is used, since nested groups are not supported for MySQL.
-
- 16 May, 2017 1 commit
-
-
Douwe Maan authored
Rename `build_events` to `job_events` Closes #31620 See merge request !11287
-
- 15 May, 2017 2 commits
-
-
Douwe Maan authored
This reverts merge request !11287
-
Bob Van Landuyt authored
-
- 10 May, 2017 2 commits
-
-
Rémy Coutable authored
Use the EnforcedStyleForMultiline: no_comma option. Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Use the EnforcedStyleForMultiline: no_comma option. Signed-off-by:
Rémy Coutable <remy@rymai.me>
-