Read about our upcoming Code of Conduct on this issue

  1. 06 Dec, 2019 2 commits
  2. 05 Dec, 2019 1 commit
  3. 13 Nov, 2019 1 commit
  4. 03 Oct, 2019 1 commit
  5. 27 Sep, 2019 1 commit
  6. 25 Sep, 2019 1 commit
  7. 24 Sep, 2019 1 commit
  8. 09 Aug, 2019 1 commit
  9. 09 Jul, 2019 1 commit
  10. 25 Jun, 2019 3 commits
  11. 30 Apr, 2019 1 commit
  12. 04 Mar, 2019 1 commit
  13. 06 Feb, 2019 2 commits
  14. 13 Jan, 2019 1 commit
    • Stan Hu's avatar
      Fix no avatar not showing in user selection box · 10678c63d8a8
      Stan Hu authored
      After upgrading to Ruby 2.5.3, we switched `URI.join` in favor of
      `Gitlab::Utils.append_path`. However,
      ActionController::Base.helpers.image_path can return a full URL if a CDN
      host is present.
      
      Rails provides a way to generate the full URL using the asset path, but
      that doesn't appear to work because `request` is nil`.
      
      Revert to the previous behavior to handle CDNs and relative URLs.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56268
      10678c63d8a8
  15. 09 Nov, 2018 1 commit
  16. 22 Oct, 2018 1 commit
  17. 11 Oct, 2018 1 commit
    • Yorick Peterse's avatar
      Support pushing of feature flags to the frontend · ef23ab8e8ffd
      Yorick Peterse authored
      This adds a method to Gitlab::GonHelper called
      `push_frontend_feature_flag`. This method can be used to easily expose
      the state of a feature flag to Javascript code. For example, using this
      method we may write the following controller code:
      
          before_action do
            push_frontend_feature_flag(:vim_bindings)
          end
      
          def index
            # ...
          end
      
          def edit
            # ...
          end
      
      In Javascript we can then check the state of the flag as follows:
      
          if ( gon.features.vimBindings ) {
            // ...
          }
      
      Fixes https://gitlab.com/gitlab-org/release/framework/issues/17
      ef23ab8e8ffd
  18. 31 May, 2018 1 commit
  19. 29 May, 2018 1 commit
  20. 24 May, 2018 1 commit
  21. 02 May, 2018 1 commit
  22. 05 Mar, 2018 1 commit
  23. 01 Mar, 2018 1 commit
  24. 02 Feb, 2018 1 commit
  25. 03 Jan, 2018 1 commit
  26. 21 Dec, 2017 2 commits
  27. 09 Nov, 2017 1 commit
  28. 22 Sep, 2017 1 commit
  29. 07 Sep, 2017 1 commit
  30. 05 Sep, 2017 2 commits
  31. 31 Aug, 2017 1 commit
    • Sean McGivern's avatar
      `current_application_settings` belongs on `Gitlab::CurrentSettings` · e1c28a485974
      Sean McGivern authored
      The initializers including this were doing so at the top level, so every object
      loaded after them had a `current_application_settings` method. However, if
      someone had rack-attack enabled (which was loaded before these initializers), it
      would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
      have that method.
      
      To fix this:
      
      1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
         `Object.new.current_application_settings` to work.
      2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
         like that in several places.
      3. Change the initializers to use that new form.
      e1c28a485974
  32. 29 Jun, 2017 1 commit
  33. 26 May, 2017 2 commits