1. 11 Sep, 2018 2 commits
  2. 10 Sep, 2018 1 commit
  3. 09 Sep, 2018 1 commit
  4. 08 Sep, 2018 1 commit
  5. 07 Sep, 2018 5 commits
  6. 06 Sep, 2018 3 commits
  7. 05 Sep, 2018 1 commit
  8. 04 Sep, 2018 2 commits
  9. 30 Aug, 2018 2 commits
  10. 29 Aug, 2018 1 commit
  11. 26 Aug, 2018 1 commit
  12. 25 Aug, 2018 3 commits
  13. 24 Aug, 2018 1 commit
  14. 23 Aug, 2018 1 commit
  15. 22 Aug, 2018 1 commit
  16. 21 Aug, 2018 5 commits
    • Stan Hu's avatar
      Eliminate unnecessary and duplicate system hook fires · 940126e4bedb
      Stan Hu authored
      Previously `SystemHookPushWorker` would always be called after a push event,
      and this would queue a Sidekiq job regardless of whether any system hooks
      needed that event. Moreover, another call inside `Project#execute_hooks` would
      also fire system hooks if they existed.
      
      This change both removes the duplicate system hook calls. For installations
      without system hooks for push events, this change also can save significant
      amount of RAM used by Redis.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/50549
      940126e4bedb
    • Sean McGivern's avatar
      Only load issue notes once when getting related MRs · 89f01d678db9
      Sean McGivern authored
      As we always call both methods from the controller - and elsewhere we call the
      more general method - and one uses all notes and the other uses system notes,
      then we should just load the notes and their authors once, and filter on the
      Ruby side.
      89f01d678db9
    • Sean McGivern's avatar
      Fix CI pipelines N+1 in Issues::ReferencedMergeRequestsService · d42fd7a4fa3a
      Sean McGivern authored
      Whether the preloading belongs in the service or the controller is arguable,
      here. As the service is only used for one controller action, it seems reasonable
      to put it in the service, but that is not a definitive answer.
      
      Adding the preloads for MR project routes here doesn't seem to work, perhaps
      because of https://github.com/rails/rails/issues/32140.
      d42fd7a4fa3a
    • Sean McGivern's avatar
      Fix authors N+1 in Issues::ReferencedMergeRequestsService · 05961e16d80f
      Sean McGivern authored
      `#referenced_merge_requests` preloaded too many associations. Award emoji, for
      instance, are completely unnecessary here.
      
      `#closed_by_merge_requests` had the opposite problem: `#all_references` needs
      each item's author, and these weren't preloaded.
      05961e16d80f
    • Sean McGivern's avatar
      Move Issue#{referenced,closed_by}_merge_requests to service · 8f97142bd7a9
      Sean McGivern authored
      These methods don't really need to be on the Issue model. Issue#related_branches
      can also be moved to a service, but we can do that in a separate commit.
      
      This commit does not change any behaviour; it just moves code around, renames
      the service, and refactors the specs.
      8f97142bd7a9
  17. 20 Aug, 2018 1 commit
  18. 17 Aug, 2018 1 commit
  19. 16 Aug, 2018 3 commits
  20. 14 Aug, 2018 3 commits
  21. 12 Aug, 2018 1 commit