Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
heptapod
heptapod
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 111
    • Issues 111
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • Operations
    • Operations
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards

This instance will be upgraded to Heptapod 0.19.0rc2 on 2021-01-18 at 11:00 UTC+1 (a few minutes of downtime)

  • heptapod
  • heptapodheptapod
  • Issues
  • #369

Closed
Open
Opened Nov 16, 2020 by Georges Racinet@gracinet🦑Owner

HgitalyRepository: use FindMergeBase

This is the counterpart of hgitaly#26.

This method is the one behind the computation of base SHA for Merge Requests.

Since we don't want to swap the RepositoryService as a whole (most of its RPCs are for %HGitaly3: fully in charge), we'll probably can just make a temporary hgitaly_repository_client method to access the HGitaly service instead of changing the behaviour of the existing (gitaly_repository_client).

Writing RSpec tests for the %HGitaly1: Hg SHAs time frame would be a good thing.

Assignee
Assign to
HGitaly2: fully native
Milestone
HGitaly2: fully native
Assign milestone
Time tracking
None
Due date
None
Reference: heptapod/heptapod#369