Very flaky test
This one needs up to 6 retries to pass (on GitLab 13.4.0 anyway), whereas the default upstream GitLab setting in CI is 3 retries.
It is possible though that this is a side effect of the efforts made to make our tests really work with knapsack (but the 6 retries case was actually obtained in a monoprocess direct run of this merge_request_diff_spec.rb
)
1) MergeRequestDiff#migrate_files_to_external_storage! safely handles a transaction error when migrating to external storage
Failure/Error: expect(diff.external_diff).not_to be_exists
expected `#<ExternalDiffUploader:0x000000002142b6e0 @model=#<MergeRequestDiff id: 22, state: "collected", merge...ile:0x000000002142b410 @uploader=#<ExternalDiffUploader:0x000000002142b6e0 ...>, @cache_called=nil>>.exists?` to return false, got true
# ./spec/models/merge_request_diff_spec.rb:185:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:330:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:321:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:317:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:317:in `block (2 levels) in <top (required)>'
Finished in 1 minute 24.72 seconds (files took 23.34 seconds to load)
133 examples, 1 failure
Failed examples:
rspec ./spec/models/merge_request_diff_spec.rb:183 # MergeRequestDiff#migrate_files_to_external_storage! safely handles a transaction error when migrating to external storage