Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
heptapod
heptapod
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 116
    • Issues 116
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • Operations
    • Operations
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

There will be about 1h of downtime on 2020-03-02 at 13:00 UTC+1 (change of servers and upgrade to Heptapod 0.20.0 final)

  • heptapod
  • heptapodheptapod
  • Merge Requests
  • !15

Closed
Opened Apr 03, 2019 by Georges Racinet@gracinet🦑Owner
  • Report abuse
Report abuse

hg_http_controller: avoid masking some errors

  • Overview 5
  • Commits 1
  • Changes 1

In case the inner HTTParty call to hgserve didn't get to a conclusion (e.g., because of a timeout), hgserve response doesn't have its Content-Type set, and this ends up as:

ArgumentError (:type option required): app/controllers/projects/hg_http_controller.rb:79:in `hg_post'

because we try and return our own response without a proper Content-Type. In this changeset, we add a default Content-Type to avoid this masking.

If hgserve would itself have a bug leading it to incorrectly send us a response without a proper Content-Type, we would similarly not mask what happens with this ArgumentError

--HG-- branch : heptapod

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: heptapod/heptapod!15
Source branch: topic/heptapod/improve-error-log