WIP Fully native Mercurial without Git: unacceptable diversions

These shortcuts are enough to make the functional tests pass, but
they are of course unacceptable. Insted, this changeset expresses
the things that will need to be implemented to merge into
the heptapod branch.

--HG--
branch : hgitaly2
4 jobs for !290 with topic/hgitaly2/no-git-conversion in 22 minutes and 34 seconds (queued for 12 minutes and 57 seconds)
detached
Status Name Job ID Coverage
  Lint
failed rubocop #253086

00:22:34

 
  Test
passed workhorse:test using go 1.15 #253088

00:08:12

passed workhorse:test using go 1.16 #253089

00:08:03

passed workhorse:verify #253087

00:06:46

 
Name Stage Failure
failed
rubocop Lint
        Rails.logger.info("testgr diverted copy_gitattributes")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/mercurial/hgitaly_repository.rb:259:9: C: Gitlab/RailsLogger: Use a structured JSON logger instead of Rails.logger. https://docs.gitlab.com/ee/development/logging.html
Rails.logger.info("testgr diverted clean_stale_repository_files")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

18130 files inspected, 7 offenses detected
Cleaning up file based variables
ERROR: Job failed: exit code 1