GetTreeEntries: testing and fixing some corner cases
Testing the case of `limit=0` and revision unknown uncovered a small difference between HGitaly and Gitaly (RHGitaly was already compliant): HGitaly was returning a response, with an empty list of entries. Decided to change `chunked()` to avoid yielding an empty chunk, but it turned out that `RepositoryService.SearchFilesByName` was actually expected to yield responses with empty lists, hence we hade to make it optional. The check in `CommitService` to avoid empty chunks having become default, we had to remove it to kepp coverage.
parent
63daae2a
No related branches found
No related tags found
Showing
- hgitaly/service/commit.py 0 additions, 2 deletionshgitaly/service/commit.py
- hgitaly/service/repository.py 2 additions, 1 deletionhgitaly/service/repository.py
- hgitaly/util.py 6 additions, 2 deletionshgitaly/util.py
- rust/rhgitaly/src/service/commit.rs 2 additions, 2 deletionsrust/rhgitaly/src/service/commit.rs
- tests_with_gitaly/test_blob_tree.py 9 additions, 1 deletiontests_with_gitaly/test_blob_tree.py
Loading
Please register or sign in to comment