Skip to content
Snippets Groups Projects
Commit dee21e96 authored by Georges Racinet's avatar Georges Racinet
Browse files

Gitaly Comparision test_tree_entry_requests: giving up on comparing chunk size

Basically, Gitaly chunk lengths are partly unpredictable. We tried to approximate
them, but we can't really depend on them in assertions.

The irritating thing is that this test failed often in CI (clear majority of runs,
yet not all of them) and passed almost always on my development setup. The CI
flakiness is now too much of a pain to keep it.

Passing the `compare_first_chunks=False` does not change the fact that the
entire content is compared and that metadata (aka small fields or unchunked fiels)
are compared for all chunks (added a clarification in docstring about that).
parent 81a84397
No related branches found
No related tags found
2 merge requests!151heptapod#743: making 0.36 the new stable,!148Gitaly Comparision test_tree_entry_requests: giving up on comparing chunk size
Pipeline #66119 passed
......@@ -321,7 +321,8 @@
(typically the number of responses would differ).
:param bool compare_first_chunk: if ``True``, the first chunks of
both responses are directly compared (including main content).
both responses are directly compared (including main content). If
``False``, they are still compared, just ignoring main content.
:param bool check_both_chunked: if ``True` checks that we get
more than one response for both HGitaly and Gitaly
:return: a pair: the first chunk of responses for Gitaly and HGitaly
......
......@@ -162,7 +162,8 @@
(default_rev, b'sub/ba2', 'blob'),
(default_rev, b'foo', 'blob'),
)))
rpc_helper.assert_compare_aggregated(path=b'bigfile')
rpc_helper.assert_compare_aggregated(path=b'bigfile',
compare_first_chunks=False)
#
# reusing content to test GetTreeEntries, hence with a new rpc_helper
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment