1. 05 Jul, 2021 3 commits
  2. 31 May, 2021 2 commits
    • Georges Racinet's avatar
      CommitService logging all incoming requests · dcef6bbdc59a
      Georges Racinet authored
      In some cases this replaces existing logs with the more complete
      dump of the request.
      
      Again, it's not useful to put the name of the method in the message:
      the name of the request class fulfills that purpose easily.
      dcef6bbdc59a
    • Georges Racinet's avatar
      RefService logging all incoming requests · 06e62bed644b
      Georges Racinet authored
      We don't need to include the method name in the log message,
      because of the Gitaly protocol conventions: each method has
      its own, dedicated Request class, whose name is already part of
      the rendering.
      06e62bed644b
  3. 01 Jul, 2021 2 commits
  4. 21 Mar, 2021 2 commits
  5. 20 Mar, 2021 1 commit
  6. 17 Jun, 2021 5 commits
  7. 16 Jun, 2021 1 commit
  8. 26 May, 2021 5 commits
  9. 25 Mar, 2021 2 commits
  10. 23 Mar, 2021 1 commit
  11. 25 May, 2021 1 commit
  12. 04 Apr, 2021 1 commit
    • Georges Racinet's avatar
      message: wrapper class for easy logging · 10be0d6ac733
      Georges Racinet authored
      With gRPC, the `repr` of messages, notably Gitaly Requests
      is made of multiple lines.
      This is very bad for logging: a log should always be made of
      a single line for:
      
      - meaningful grepping
      - detangling when several processes log to the same file
      
      We want in particular service method to be able to log
      easily their incoming requests and/or more messages, but
      we want the formatting to be done only if the log is
      actually to be emitted (important to avoid debug logs to
      make production servers choke). This is usually achieved with
      the following pattern, because logging evaluation is inherently
      lazy.
      
      ```python
      logging.debug('the interesting object is %r', obj)
      ```
      
      We could use extras, as `hg-loggingmod` does for the repository,
      but that is evaluated in the final formatting of the entire log
      line, and requires to register a specific format, then a specific
      handler to use it.
      
      The provided solution (wrapping in a class), is not zero-cost,
      but is expected to be cheap enough for the time being.
      10be0d6ac733
  13. 18 May, 2021 1 commit
  14. 25 Apr, 2021 2 commits
  15. 24 Apr, 2021 1 commit
  16. 22 Apr, 2021 10 commits