- Oct 20, 2021
-
-
Georges Racinet authored
Perhaps at some point Gitaly will decide that the proper error code should be `NotFound` or to stop providing the full path in the details, but we are meanhile doing the same. The only difference in error treatment is the replacement of 'git repository` by 'Mercurial repository' but as usual I'm betting on it not to matter.
-
- Oct 11, 2021
-
-
Georges Racinet authored
-
Georges Racinet authored
-
- Sep 09, 2021
-
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
(Ruby gem version updated by gRPC generation script)
-
Georges Racinet authored
This may be necessary to run the gem generation script on hosts without a system-wide `ruby` executable.
-
Georges Racinet authored
It remains true that if `limit` is 0, then empty results are expected, but absence of the `PaginationParameter` field is used by Gitaly to mean no pagination. In particular comments about breaking change for clients in bb607763822c were just wrong.
-
Georges Racinet authored
It turns out that presence of the `PaginationParameter` field is testable after all, and that requires access to the whole request object.
-
Georges Racinet authored
Since the branch information is encoded in the changeset, we have no choice other that to interpret the update time as the time also encoded in the changeset. This of course has nothing to do with the time of push to the server.
-
- Sep 08, 2021
-
-
Georges Racinet authored
As previously done for `ListLocalBranches`, we're going for correctness over keeping nice internal iterators (which are largely artificial because ultimately the manifest is not very convenient).
-
Georges Racinet authored
It was useful for debugging purposes to have a mapping with paths as keys, but now we're going to perform assertions on the ordering.
-
Georges Racinet authored
This is exposed via GraphQL to the front side.
-
- Sep 06, 2021
-
-
Georges Racinet authored
This completes the pagination parameters implementation. There is a protocol discrepancy, the page token (str) is supposed to be comparable with branch names (bytes), but still that is an inequality, it is less problematic than if the logic was to iterate until an exact match occurs (as is the case with paginated methods providing OIDs).
-
Georges Racinet authored
Pagination parameters in general are new in Gitaly 14.2. Wherever used, they create a breaking change, because the default value for `limit` is 0, and that means to really cut at 0 (hence return empty responses). In the case of FindLocalBranches, the method response is exposed in the Rails app in `app/finders/branches_finder`, which is itself used in several controllers and services.
-
Georges Racinet authored
What would be the point of deduplicating helpers if it was easy to forget about them?
-
Georges Racinet authored
The new fixture will help reduce boilerplate and its duplication.
-
- Sep 02, 2021
-
-
Georges Racinet authored
Seems to have several new RPCs (listing blobs etc) and options (sorting, notably).
-
Georges Racinet authored
With the upcoming protocol bump for GitLab 14.2, this only makes sense.
-
- Sep 06, 2021
-
-
Georges Racinet authored
Brings in the proto update for GitLab 14.0 and several improvements in HGitaly specific code.
-
Georges Racinet authored
The expected response was actually in full ref form (as `refs/heads`). It is probable that the Rails app is resilient with respect to that. Gitaly response is sorted (bad for perf, but nothing obvious we can do, GitLab 14.2 will even introduce different sorting criteria). This RPC method was implemented before we had Gitaly Comparison tests, this underlines once more how crucial they are.
-
- Aug 24, 2021
-
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
This is empty, since the oldstable branch hasn't seen any real activity since Heptapod 0.20. Yet that's one item less to check for next releases.
-
- Aug 23, 2021
-
-
Georges Racinet authored
We have a bump of protocol, even if it looks to be orthogonal to Mercurial concerns
-
Georges Racinet authored
Notable differences: - The Golang library package path now based on the major version number (`/v14') - RPC methods for remote mirror updating (should be only in the push direction). - Removal of some Wiki methods.
-
- Aug 04, 2021
-
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
(should have been done before tag)
-
Georges Racinet authored
-
Georges Racinet authored
-
- Aug 03, 2021
-
-
Georges Racinet authored
-
- Jul 19, 2021
-
-
Georges Racinet authored
Closes #55 Since we're only removing special refs, comparison to Gitaly has to be understood as assuming that only special refs will be removed on the Git side, which we arrange for directly.
-
Georges Racinet authored
This `assert_compare()` makes for shorter assertion lines, whose meaning is hopefully quicker to grasp.
-
Georges Racinet authored
This should distract readers a bit less.
-
Georges Racinet authored
This will make forthcoming code for `except_prefix` easier to integrate.
-
Georges Racinet authored
Although the `repository_service` comes from Gitaly itself (proto file name), if we strip it down from the class, let's also do it for the module name.
-
- May 28, 2021
-
-
Sushil Khanchi authored
-