# HG changeset patch # User Marin Jankovski <maxlazio@gmail.com> # Date 1514218564 -3600 # Mon Dec 25 17:16:04 2017 +0100 # Node ID bb6d370919151eddf08b9b58d171a4ffc8896ab8 # Parent d308ed693c9540971b9d880fcc7242c4ebcac875 Add a line about definition of done in CONTRIBUTING guide. [CI skip] diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,6 +17,16 @@ _This notice should stay as the first item in the CONTRIBUTING.md file._ +## Definition of done + +The omnibus-gitlab project uses the [definition of done as noted in GitLab Community Edition (and Enterprise Edition)](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#definition-of-done). + +As this project is a wrapper around GitLab CE/EE, some additions to the definition apply: + +1. Integration tests using [GitLab QA](https://gitlab.com/gitlab-org/gitlab-qa). +1. Green pipelines in both [gitlab.com pipelines](https://gitlab.com/gitlab-org/omnibus-gitlab/pipelines) (Specs) and +[dev.gitlab.org pipelines](https://dev.gitlab.org/gitlab/omnibus-gitlab/pipelines) (Package builds). This rule is at minimum applicable to the reviewers. + ## General issue guidelines