Skip to content
Snippets Groups Projects
  1. Jul 05, 2024
  2. Jul 03, 2024
  3. Jul 02, 2024
  4. Jun 26, 2024
    • Stan Hu's avatar
      Attempt to retry twice to determine Redis server version · 91afd5f5
      Stan Hu authored
      We had two different customers upgrade GitLab and run into `stderr:
      Error: Connection reset by peer` when attempting to determine the
      Redis version. This appears to have occurred because `gitlab-ctl
      reconfigure` can restart Redis right before it checks the version.
      This causes the `gitlab-ctl reconfigure` to fail outright.
      
      To avoid this failure mode, set the Chef `retries` parameter to 2. By
      default the `retry_delay` is 2 seconds.
      
      Relates to
      https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8597
      
      Changelog: fixed
      91afd5f5
  5. Jul 02, 2024
  6. Jun 27, 2024
  7. Jul 02, 2024
  8. Jun 27, 2024
    • Stan Hu's avatar
      Fix Redis password handling with reserved characters · ba009e3b
      Stan Hu authored
      Previously including reserved characters such as `@` in the Redis
      password would fail because `URI::Generic::DEFAULT_PARSER.escape` did
      not consider `@` unsafe, which it generally isn't per RFC 2396 and
      3986. However, the `@` is not allowed in the userinfo field, and the
      URI builder for Ruby fails if using a reserved character were
      included.
      
      To fix this, use `ERB.url_encode`, which always escapes any
      non-alphanumeric string.
      
      Relates to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8602
      
      Changelog: fixed
      ba009e3b
  9. Jul 01, 2024
  10. Jun 25, 2024
  11. Jun 24, 2024
  12. Jun 28, 2024
  13. Jun 27, 2024
  14. Jun 26, 2024
  15. Jun 25, 2024
  16. Jun 24, 2024
  17. Jun 18, 2024
  18. Jun 24, 2024
  19. Jun 04, 2024
  20. Jun 24, 2024
  21. Jun 12, 2024
    • Vasilii Iakliushin's avatar
      Disable request buffering for new SSH endpoints · ed3f9dbb
      Vasilii Iakliushin authored
      Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/466160
      
      **Problem**
      
      While testing the new implementation of SSH endpoints for git related
      actions. I noticed a problem reproducible in my
      local environment.
      
      The request from GitLab-Shell to Workhorse was hanging. After in
      investigation I discovered the root cause of this problem.
      
      In our NGINX configuration we use request buffering. After adding the
      new endpoint to the list of exceptions, then problem was resolved.
      
      **Solution**
      
      Add new endpoints to the list of exceptions for nginx configuration.
      
      Changelog: changed
      ed3f9dbb
Loading