Skip to content
Snippets Groups Projects
  1. Jan 27, 2022
  2. Jan 26, 2022
  3. Dec 24, 2021
  4. Jan 26, 2022
  5. Dec 16, 2021
  6. Jan 25, 2022
  7. Jan 24, 2022
  8. Dec 01, 2021
  9. Nov 09, 2021
  10. Nov 08, 2021
  11. Nov 03, 2021
  12. Aug 06, 2021
  13. Jul 19, 2021
  14. Jan 24, 2022
  15. Jan 09, 2022
    • Fabio Huser's avatar
      Correct GitLab KAS default redis port configuration · e4741d6c015c
      Fabio Huser authored
      Using gitlab-kas with an external redis instance (`gitlab_rails['redis_host']`
      set to e.g. `my-redis`) but default port configuration (`gitlab_rails['redis_port']`
      not set) leads to an invalid redis hostname/port combination (e.g. `my-redis:`
      instead of `my-redis:6379`). This configuration works perfectly fine for other
      GitLab services (e.g. workhorse, gitlab-rails) and is also covered by unit-tests
      (see spec/libraries/redis_helper_spec.rb#59). Those services rely on the
      `redis_url` method which properly omits the default redis port completely,
      whereas gitlab-kas derives the hostname/port combination from the two values
      directly but not taking a default port value into account. This commit changes
      that behavior by adding a fall-back default redis port, in case no custom one is
      set and the tcp connection method is used.
      
      Changelog: fixed
      e4741d6c015c
  16. Jan 24, 2022
  17. Jan 21, 2022
  18. Jan 19, 2022
  19. Jan 21, 2022
  20. Jan 20, 2022
  21. Jan 21, 2022
  22. Jan 14, 2022
  23. Jan 19, 2022
Loading