Skip to content
Snippets Groups Projects
Commit 33d26f7b authored by Matt Harbison's avatar Matt Harbison
Browse files

infinitepush: open files in binary mode

This fixes the scary looking abort in test-infinitepush-ci.t when unbundling:

  --- tests/test-infinitepush-ci.t
  +++ tests/test-infinitepush-ci.t.err
  @@ -84,15 +84,12 @@

     $ hg unbundle .hg/scratchbranches/filebundlestore/a4/c2/a4c202c147a9c4bb91bbadb56321fc5f3950f7f2
     adding changesets
  -  adding manifests
  -  adding file changes
  -  added 1 changesets with 1 changes to 1 files
  -  new changesets 6cb0989601f1
  -  (run 'hg update' to get a working copy)
  -
  -  $ hg glog
  -  o  1:6cb0989601f1 added a
  -  |  public
  +  transaction abort!
  +  rollback completed
  +  abort: stream ended unexpectedly  (got 68 bytes, expected 218759168)
  +  [255]
  +
  +  $ hg glog
     @  0:67145f466344 initialcommit
        public

This was found by grepping for '"r', "'r", '"w' and "'w" after manually creating
a bundle from the same revision, diffing against the corrupt one, and seeing CRs
sprinkled around.  Sadly, the missing bookmarks are still a problem in the two
remaining test failures.
parent 72ccb071
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment