Skip to content
  • Gregory Szorc's avatar
    pathencode: use Py_SIZE directly · a8c948ee3668
    Gregory Szorc authored
    On Python 2, PyBytes_GET_SIZE is the same as PyString_GET_SIZE which
    is the same as Py_SIZE which resolves to a struct member.
    
    On Python 3, PyBytes_GET_SIZE is
    "(assert(PyBytes_Check(op)),Py_SIZE(op))". The compiler barfs when
    assigning to this version.
    
    This patch simply changes PyBytes_GET_SIZE to Py_SIZE. On Python 2,
    there is no effective change in behavior. On Python 3, we drop the
    PyBytes_Check(). However, in all cases we have explicitly created
    a PyBytesObject in the same function, so the PyBytes_Check() is
    guaranteed to be true. Despite this, code changes over time, so
    I've added added assert() in all callers so we can catch this in
    debug builds.
    
    With this patch, all mercurial.* C extensions now compile on Python 3
    on my OS X machine. There are several compiler warnings and I'm sure
    there are incompatibilities with Python 3, including possibly
    segfaults. But it is a milestone.
    a8c948ee3668