Skip to content
Snippets Groups Projects
Commit 28a061aee52d authored by Matt Harbison's avatar Matt Harbison
Browse files

xxx-windows: avoid replacing `sys.__std{in,out,err}__`

PyCharm was yapping that these are final, but when I commented them out, I got
a very early crash related to checking isatty() on a closed file descriptor.
This fixes that, though I suspect it would be even simpler to do the replacement
in the windows module.  On the one hand, we do want this setup very early in the
process.  OTOH, the pager isn't configured until after stdio is customized.  And
if there is some error output that happens before that, writing bytes without
the pager and without enabling legacy stdio seems to work.

Aside: I wonder why we have custom line buffering classes in procutil if there's
line buffering setup on stdio in dispatch, just below this.  A python2 holdover
maybe?
parent 7905b7bc4b21
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment