Skip to content
Snippets Groups Projects
Commit 599912a6 authored by Katsunori FUJIWARA's avatar Katsunori FUJIWARA
Browse files

transaction: open a file with checkambig=True to avoid file stat ambiguity

Before this patch, if steps below occurs at "the same time in sec",
all of mtime, ctime and size are same between (1) and (3).

  1. append data to revlog-style file (and close transaction)
  2. discard appended data by truncation of rollback
  3. append same size but different data to revlog-style file again

Therefore, cache validation doesn't work after (3) as expected.

To avoid file stat ambiguity around truncation, this patch opens a
file with checkambig=True.

This is a part of ExactCacheValidationPlan.

    https://www.mercurial-scm.org/wiki/ExactCacheValidationPlan
parent e38d85be
No related branches found
No related tags found
No related merge requests found
......@@ -48,7 +48,7 @@
for f, o, _ignore in entries:
if o or not unlink:
try:
fp = opener(f, 'a')
fp = opener(f, 'a', checkambig=True)
fp.truncate(o)
fp.close()
except IOError:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment