Skip to content
Snippets Groups Projects
  1. Jun 02, 2022
  2. May 04, 2022
    • idlsoft's avatar
      narrow_widen_acl: enforce narrowacl in narrow_widen (SEC) · 6b10151b
      idlsoft authored
      Reviewer note: this was sent by the author as a simple bugfix, but can be
      considered a security patch, since it allows users to access things outside
      of the ACL, hence the (SEC) prefix.
      
      However, this affects the `narrow` extention which is still marked as
      experimental and has relatively few users aside from large companies with
      their own security layers on top from what we can gather.
      We feel (Alphare: or at least, I feel) like pinging the packaging list is
      enough in this case.
  3. May 30, 2022
    • Raphaël Gomès's avatar
      chg: ignore already closed fds when cleaning up · 20122284
      Raphaël Gomès authored
      This should fix this error we see in the CI from time to time:
      
      ```
      --- /tmp/mercurial-ci/tests/test-chg.t
      +++ /tmp/mercurial-ci/tests/test-chg.t.err
      @@ -187,6 +187,26 @@
         $ chg bulkwrite --pager=on --color no --config ui.formatted=True
         paged! 'going to write massive data\n'
         killed! (?)
      +  Traceback (most recent call last):
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/commandserver.py", line 509, in _serverequest
      +      sv.cleanup()
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/chgserver.py", line 382, in cleanup
      +      self._restoreio()
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/chgserver.py", line 461, in _restoreio
      +      os.close(fd)
      +  OSError: [Errno 9] Bad file descriptor
      +  Traceback (most recent call last):
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/commandserver.py", line 693, in _acceptnewconnection
      +      self._runworker(conn)
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/commandserver.py", line 744, in _runworker
      +      prereposetups=[self._reposetup],
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/commandserver.py", line 509, in _serverequest
      +      sv.cleanup()
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/chgserver.py", line 382, in cleanup
      +      self._restoreio()
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/chgserver.py", line 461, in _restoreio
      +      os.close(fd)
      +  OSError: [Errno 9] Bad file descriptor
         [255]
      ```
      20122284
  4. May 29, 2022
  5. May 24, 2022
  6. May 22, 2022
  7. May 17, 2022
    • Matt Harbison's avatar
      worker: adapt _blockingreader to work around a python3.8.[0-1] bug (issue6444) · 2fe4efaa
      Matt Harbison authored
      Python 3.8.0 is the latest I can load on Ubuntu 18.04, and I regularly hit the
      TypeError because this function is missing.  While it can be avoided by
      disabling worker usage via config option, that's a bit obscure.
      
      I'm limiting the function definition to the narrow range of affected pythons
      because there were other bugs in this area that were worked around, that I don't
      fully understand.  See the bug report for discussions on why the narrow range,
      and related commits working around other bugs.
      
      Differential Revision: https://phab.mercurial-scm.org/D12627
      2fe4efaa
  8. May 04, 2022
  9. May 19, 2022
  10. May 17, 2022
  11. May 16, 2022
    • Pierre-Yves David's avatar
      ci: do not trigger phabricator for merge-request · 477b5145
      Pierre-Yves David authored
      The fast the phabricator steps has a `rules` entry makes it selected for the
      special `merge_requests` pipelines. The other ones behave as default and are not
      selected tot the mrege_request pipelines.
      
      This result in a second pipeline to be created, with only the phabricator
      pipeline in it. Which usually succeed fast (since there is nothing to do).
      
      This is harmful as this create a false sense of "the series is passing" and
      Gitlab will use this simplistic pipeline for validation.
      
      By explicitly preventing the pipeline to be created in the merge-request case,
      we prevent this situation to happens
      
      Note that the job will be dropped (alonside phabricator) in the next two weeks
      anyway.
      477b5145
  12. May 12, 2022
    • Kyle Lippincott's avatar
      amend: stop specifying matcher, get all copies in wctx · df68d64b
      Kyle Lippincott authored
      When we're recreating the commit that we'll be committing, we don't want to
      filter our copy information based on just the *new* [versions of the] files
      we're amending. The test has an example of this case, but for clarity, the
      situation is:
      
      ```
      $ hg cp src dst && hg commit
      <do some work>
      $ hg amend some_unrelated_file.txt
      $ hg status --copies
      A dst
      A some_unrelated_file.txt
      ```
      
      What *should* happen is that `dst` should remain marked as a copy of `src`, but
      this did not previously happen. `matcher` here only includes the files that were
      specified on the commandline, so it only gets the copy information (if any, in
      this example there's not) for `some_unrelated_file.txt`. When it goes to apply
      the memctx to actually create the commit, the file copy information is
      incomplete and loses the information for the files that shouldn't have been
      affected at all by the amend.
      
      Differential Revision: https://phab.mercurial-scm.org/D12625
      df68d64b
    • Kyle Lippincott's avatar
  13. May 04, 2022
  14. Apr 22, 2022
  15. May 04, 2022
  16. May 03, 2022
  17. May 04, 2022
  18. Apr 28, 2022
  19. May 03, 2022
  20. Apr 25, 2022
  21. Apr 19, 2022
    • Raphaël Gomès's avatar
      rhg: use `Command::exec` instead of `Command::status` · 006688e3
      Raphaël Gomès authored
      `rhg` is supposed to be a transparent executable, using a subprocess defeats
      that purpose. See inline comments for more details.
      
      This also introduces the `which` crate to check if the fallback executable
      actually exists to help debugging (plain `execve` doesn't give much
      information).
      
      The error code 253 is used to signify that the fallback is not found, but may
      mean in the future that it is otherwise invalid if we start being more
      specific.
      
      Differential Revision: https://phab.mercurial-scm.org/D12578
      006688e3
  22. Apr 27, 2022
  23. Apr 21, 2022
  24. Apr 13, 2022
Loading