Skip to content
Snippets Groups Projects

setup: further improve the error path for version retrieval

Merged Pierre-Yves David requested to merge topic/stable/more-version-fix into branch/stable
  1. Feb 17, 2023
    • Pierre-Yves David's avatar
      setup: further improve the error path for version retrieval · 010a1e73f69e
      Pierre-Yves David authored
      This is a new take at the problem that 8d390a13474d tried to tackle. There was
      two issues after that previous improvement:
      
      - the 0.0+ version could survive a bit too long and reaching the installer
        version and staying there.
      - multiple use case where still failing.
      
      So the new code is better at:
      - always succeeding when running `make local` so that we can
        bootstrap a local version
      - no using that fallback outside of `make local` to avoid distribution of
        version with the buggy version number.
      
      The setup.py is a gigantic pile of spaghetti code, to the point where
      pastafarian pilgrim started knocking at its core.
      
      However I refrained from cleaning that up since the more to a `setup.cfg` means
      this code should be deleted soon™.
      010a1e73f69e
Loading