Skip to content
Snippets Groups Projects

introduce subclass for delta-search

Merged Pierre-Yves David requested to merge topic/default/better-delta.class-split into branch/default
  1. Nov 23, 2023
  2. Jan 07, 2024
  3. Nov 23, 2023
  4. Jan 07, 2024
    • Pierre-Yves David's avatar
      delta-find: explicitly deal with usage of the cached revision · 7083b33a2699
      Pierre-Yves David authored
      We can remove this from the general logic path and directly deal with this
      corner case early.
      
      This result in a small change in test-generaldelta.t as it turns out that:
      
      - at commit time we (sometimes) precompute a delta against p1 and pass it as the
        cached delta.
      - since cached delta where going through the same filtering as everything, we
        could "optimize" the base if it applied to an empty delta, resulting in not
        using the pre-computed delta.
      
      The simpler logic fix the second item, making the cached delta base always actually
      tested when requested.
      
      Note that the computation of a fast delta against p1 only is questionable, but
      looking into that is out of scope for this series.
      7083b33a2699
    • Pierre-Yves David's avatar
      delta-find: remove the "candidate groups" layer · bbbfa00d1e67
      Pierre-Yves David authored
      We have enough pieces to remove this generator and directly bear it load using
      the underlying object.
      bbbfa00d1e67
    • Pierre-Yves David's avatar
      delta-find: stop using heuristic to determine if we are creating a snapshot · 670e68729aa7
      Pierre-Yves David authored
      This avoid assuming a changeset is a snapshot when it is actually something
      simpler.
      670e68729aa7
    • Pierre-Yves David's avatar
      delta-find: explicitly track stage of the search · cc806f20d756
      Pierre-Yves David authored
      Being more explicit about what we are doing is going to be useful. We actually
      start making use of it in later changesets.
      cc806f20d756
  5. Nov 23, 2023
  6. Jan 07, 2024
  7. Jan 06, 2024
  8. Jan 04, 2024
  9. Nov 23, 2023
  10. Jan 04, 2024
  11. Nov 23, 2023
  12. Dec 29, 2023
  13. Nov 23, 2023
    • Pierre-Yves David's avatar
      delta-find: use "-1" as depth snapshot-dept for non snapshot in debug · 0d92d62ecde0
      Pierre-Yves David authored
      This will help do distinct full snapshot (level 0) and normal delta (not a snapshot, no snapshot level)
      0d92d62ecde0
    • Pierre-Yves David's avatar
      delta-find: fix the computation of the `prev` value · 2e169a222e63
      Pierre-Yves David authored
      The previous computation was "wrong" it always used the tiprev, even when computing a delta in a non-append case (mostly benchmark).
      
      This never produced wrong delta on disk, but would misled debug or performance command. Since it does not have any actual user impact, I did not put this on stable.
      
      With the code fixed we can now use revisions in some search and it makes the
      test display more interesting behavior since the algorithm has more to work
      with.
      2e169a222e63
  14. Dec 22, 2023
  15. Nov 23, 2023
  16. Nov 20, 2023
  17. Dec 22, 2023
Loading