- 04 Mar, 2021 5 commits
-
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
Marcin Kasperski authored
seems to work more or less.
-
Marcin Kasperski authored
Topic/default/py3 fixes See merge request !16
-
- 28 Feb, 2021 2 commits
-
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
- 22 Feb, 2021 1 commit
-
-
Chris Wesseling authored
-
- 21 Feb, 2021 2 commits
-
-
Matt Harbison authored
Aside from the customization of fetching the password from the store, I left the default config arg for `smtp.tls` and the `util.safehasattr(socket, 'ssl')` check for TLS to support ancient Mercurial versions. I think this area could be improved greatly by changing Mercurial to have a separate function that fetches the username/password that this extension could wrap and replace, and another function that can be given a username/password to try the login. That would eliminate a lot of code duplication that I'm not entirely convinced is py3 safe in core Mercurial, such as passing the exception to `error.Abort` a couple lines below.
-
Matt Harbison authored
Mercurial both wants and returns bytes from these.
-
- 20 Feb, 2021 4 commits
-
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
- 02 Feb, 2021 1 commit
-
-
Dan Villiom Podlaski Christiansen authored
Without this patch, the extension only works under Python 3.9 if you disable demandimport.
-
- 23 Nov, 2020 2 commits
-
-
Matt Harbison authored
This is a thin wrapper around `mercurial.i18n._()` and as noted in the previous commit, that is not meant to handle unicode. We could fix that function to convert internally before passing through, but I'm used to passing bytes to these Mercurial internals, and every time I saw it I thought these needed to be fixed. Additionally, if translations are ever made, it should probably be done in the same manner as core Mercurial (based on bytes). The trailing arguments are converted to bytes by `ui_string()` before interpolation, so this won't introduce any incompatabilities.
-
Matt Harbison authored
As noted in 4a2d0ce50f5a, it's not intended for _() to convert from unicode, and it doesn't always work. For the uses where values are interpolated, they will not be `None`, given the checks that precede them.
-
- 22 Nov, 2020 3 commits
-
-
Matt Harbison authored
At this point, there are no more things that pytype is flagging, so it will need some annotations on core Mercurial code.
-
Matt Harbison authored
The makefile and config file were copied from TortoiseHg. The location of the `mercurial-extension_utils` repo is assumed to be next to this repo for simplicity.
-
Matt Harbison authored
I hit this in various test-check-* tests for Mercurial when running on a zstd repo without the C extensions, but this can be trivially reproduced with `HGPLAIN=1`: *** failed to import extension mercurial_keyring: unicode 'keyring_check [PATH]' found in cmdtable.keyring_check *** (use b'' to make it byte string) The issue is that `i18n._()` wants bytes, but leaves a backdoor for `str` for docstrings. That backdoor is closed if `HGPLAIN` or `HGPLAINEXCEPT` is set (unless `i18n` is set in `HGPLAINEXCEPT`). There are a bunch of other uses of this function that still need to be byteified. The global `buglink`, `testedwith`, and `minimumhgversion` also want to be bytes.
-
- 08 Aug, 2020 5 commits
-
-
Anton Shestakov authored
There were no clickable links to thg before.
-
Anton Shestakov authored
-
Anton Shestakov authored
-
Anton Shestakov authored
-
Anton Shestakov authored
An identical link already exists at the bottom of this file.
-
- 27 Jun, 2020 4 commits
-
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
- 14 Jun, 2020 2 commits
-
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
- 24 Nov, 2019 1 commit
-
-
Marcin Kasperski authored
-
- 11 Nov, 2019 4 commits
-
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
- 10 Nov, 2019 4 commits
-
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-
Marcin Kasperski authored
-