Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M mercurial_keyring
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Mercurial Paris conference scheduled ! Main event : 2022-09-22. Call for papers deadline: 2022-06-17.

  • mercurial
  • mercurial_keyring
  • Issues
  • #41

Closed
Open
Created Oct 09, 2014 by Bitbucket Importer@bitbucket_importerOwner

demandimport logic is incorrect

Created originally on Bitbucket by olliewalsh (Ollie Walsh)

The logic for demand import is incorrect. The end result is that demandimport is always enabled after importing mercurial-keyring, which causes major problems for everything imported afterwards.

#!python

# Temporarily disable demandimport to make the need of extending
# the list above less likely.
if __import__ == demandimport._import:
    demandimport.disable()
    try:
        import keyring
    finally:
        demandimport.enable()
else:
    import keyring

When demandimport is disabled, __import__ == demandimport._import.(http://selenic.com/hg/file/a1eb21f5caea/mercurial/demandimport.py#l43)

That should be: __import__ == demandimport._demandimport (http://selenic.com/hg/file/a1eb21f5caea/mercurial/demandimport.py#l170)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking