# HG changeset patch # User Philippe Pepiot <philippe.pepiot@logilab.fr> # Date 1526547759 -7200 # Thu May 17 11:02:39 2018 +0200 # Node ID 26e13d59a444de23e4a139b0f52f1bf450a2d8e6 # Parent 932583d14aa33c1790ba2ce0b0acbc326f2bd633 Drop param check_returncode in _single_execute() It's never used without default value (True). diff --git a/benchmarks/utils.py b/benchmarks/utils.py --- a/benchmarks/utils.py +++ b/benchmarks/utils.py @@ -208,9 +208,9 @@ times.append(func(*args, **kwargs)) return median(times) - def _execute(self, command, check_returncode=True, *args): + def _execute(self, command, *args): cmd = self._prepare_cmd(command, *args) - return self._timeit(self._single_execute, (cmd, check_returncode)) + return self._timeit(self._single_execute, (cmd,)) def _prepare_cmd(self, command, *args): cmd = [ @@ -221,26 +221,16 @@ return cmd - def _single_execute(self, cmd, check_returncode=True): + def _single_execute(self, cmd): before = time.time() - - if check_returncode is True: - try: - output = subprocess.check_output(cmd, stderr=subprocess.STDOUT, - env=self.environ) - after = time.time() - duration = after - before - return duration - except subprocess.CalledProcessError as e: - raise - else: - subprocess.call(cmd, stderr=subprocess.STDOUT, - env=self.environ) + try: + output = subprocess.check_output(cmd, stderr=subprocess.STDOUT, + env=self.environ) after = time.time() duration = after - before return duration - - + except subprocess.CalledProcessError as e: + raise class BaseTimeTestSuite(BaseTestSuite):