# HG changeset patch # User Pierre-Yves David <pierre-yves.david@octobus.net> # Date 1558288322 -7200 # Sun May 19 19:52:02 2019 +0200 # Node ID 9efcf9eb273a02aaf74f9cb09a657a4243d010a3 # Parent 41e41fd1b45c99a80a505b00cbe5115ddd2f43bf benchmark-util: fix the handling of filter_fn behing None Before, not passing a filter_fn means the function will always return False diff --git a/benchmarks/utils.py b/benchmarks/utils.py --- a/benchmarks/utils.py +++ b/benchmarks/utils.py @@ -363,8 +363,9 @@ if not match_pattern in output: in_revset = False - if filter_fn and filter_fn(test_kwargs, current_version): - in_filter = True + in_filter = True + if filter_fn is not None: + in_filter = bool(filter_fn(test_kwargs, current_version)) return in_revset and in_filter