Skip to content
  • Matt Harbison's avatar
    phabricator: add controls to specify the reviewers · b81908ea2f58
    Matt Harbison authored
    Asking the server for a list of users seems like an easy way to avoid typos, not
    knowing a reviewer's registered name, etc.  I thought about also adding a text
    edit field to directly add the name in case something goes wrong.  But the
    reviewers don't need to be specified to post the review, so let's keep the UI
    simple.
    
    I'm still thinking about adding a '--follow' to debugcallconduit to optionally
    do the cursor handling, and print a JSON list of the individual JSON blobs so
    that only one command is needed.  There's occasional progressbar jitter, and I
    can't tell if it's jerkiness during garbage collection, or transitioning between
    processing the command exiting and launching a new one.
    
    The other strange behavior I see is the list of available reviewers isn't
    sorted, even though the setDynamicSortFilter property is set on the proxy model.
    b81908ea2f58