- 23 Feb, 2020 1 commit
-
-
Matt Harbison authored
Previously, the patch was displayed `b"...."`, all in a single line with \n instead of actual linefeeds. --HG-- branch : stable
-
- 22 Feb, 2020 1 commit
-
-
Matt Harbison authored
--HG-- branch : stable
-
- 19 May, 2019 1 commit
-
-
Matt Harbison authored
Fixed up after running `2to3 -w -n -f unicode .`, and re-adding the dropped u'' prefixes. The pycompat.unicode() hack is copied into setup.py because that module declares the dependency on mercurial.
-
- 24 Feb, 2020 1 commit
-
-
Yuya Nishihara authored
We have to use pycompat version instad.
-
- 22 Feb, 2020 1 commit
-
-
Matt Harbison authored
Phabricator fails the `phabsend` if the current user is added as a reviewer.
-
- 23 Mar, 2019 1 commit
-
-
Matt Harbison authored
Fixed up after running `2to3 -w -n -f xrange .`.
-
- 03 Feb, 2019 2 commits
-
-
Matt Harbison authored
-
Matt Harbison authored
The tuple attributes are stored in unicode already. The only other place I question is in _phabsendopts(), where `**opts` will get a unicode value for the username. But that's how the tag command does it, so I assume this is proper.
-
- 22 Jan, 2019 2 commits
-
-
Matt Harbison authored
I intend to find icons that distinguish between different roles, e.g. a regular user and a mailing list. With the reviewer info being saved locally to avoid the delay of hitting the server, I think it makes sense to save this out of the gate too. Otherwise, a user that builds up a reviewer list might never refresh it from the server.
-
Matt Harbison authored
For the repositories I work with, the same reviewers are selected the vast majority of the time. I still intend to experiment with the auto completion idea, but I think this is a useful convenience with or without that.
-
- 21 Jan, 2019 1 commit
-
-
Matt Harbison authored
This avoids needing to hit the server to get a list of the previously used reviewers. The list is tied to the configured server, instead of repo specific, to build up faster.
-
- 22 Jan, 2019 1 commit
-
-
Matt Harbison authored
This makes the following changes more readable, and models how scmutil.status does it.
-
- 19 Jan, 2019 1 commit
-
-
Matt Harbison authored
-
- 15 Jan, 2019 2 commits
-
-
Matt Harbison authored
Not sure how I overlooked this before, but don't send things over the wire that we don't want.
-
Matt Harbison authored
-
- 14 Jan, 2019 1 commit
-
-
Matt Harbison authored
Asking the server for a list of users seems like an easy way to avoid typos, not knowing a reviewer's registered name, etc. I thought about also adding a text edit field to directly add the name in case something goes wrong. But the reviewers don't need to be specified to post the review, so let's keep the UI simple. I'm still thinking about adding a '--follow' to debugcallconduit to optionally do the cursor handling, and print a JSON list of the individual JSON blobs so that only one command is needed. There's occasional progressbar jitter, and I can't tell if it's jerkiness during garbage collection, or transitioning between processing the command exiting and launching a new one. The other strange behavior I see is the list of available reviewers isn't sorted, even though the setDynamicSortFilter property is set on the proxy model.
-
- 06 Jan, 2019 1 commit
-
-
Matt Harbison authored
This is a copy/paste of the email preview code, but using the export command instead of `email --test`.
-
- 30 Dec, 2018 1 commit
-
-
Matt Harbison authored
My initial attempt at this was to copy/paste/modify the ReviewBoard dialog, but I like the email dialog better- it doesn't have to manage a worker thread, and it doesn't attempt parse out errors to display a message box. Therefore, this is a copy and simplify of the email dialog. Long term, I'd like to add the preview tab back in based on `hg export`, and add controls to be able to query the server for, and specify reviewers. There are really only 2 other options: confirm and amend. Confirm doesn't make a lot of sense for the GUI, and amend is probably desired the vast majority of the time, so I'm punting on that for now. The icon is Apache 2.0 licensed from wikimedia.[1] [1] https://commons.wikimedia.org/wiki/File:Wikimedia_Phabricator_logo_unpadded.svg
-