Can't apply patch with rejected chunks when username not set
Created originally on Bitbucket by Anonymous
To repeat:
Don't set a user name
Goto a repository with an unapplied patch which will be rejected
Attempt to apply the patch
Say 'yes' to editing the file and rejected chunks
Edit the file to merge the rejected chunks and click 'Save'
At this point:
- the editor window closes without any error message
- the non-rejected files from the patch are applied to the repository
- the rejected file you edited is shown as an uncommitted file
- the patch shows as not applied in the patch queue window
- noting tells you that the save failed because the user name was not set
The error handling under the save button should be improved, and also when attempting to apply a patch it should check the user name is set before starting so that you cannot get a half-applied patch.
This is with V2.1.4