Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • thg thg
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 838
    • Issues 838
    • List
    • Boards
    • Service Desk
    • Milestones
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mercurialmercurial
  • TortoiseHgTortoiseHg
  • thgthg
  • Issues
  • #337
Closed
Open
Issue created Mar 14, 2011 by Bitbucket Importer@bitbucket_importerOwner

Shell extension is not ready for two instances of context menu

Created originally on Bitbucket by petrsolin

I'm author of Altap Salamander file manager. I have solved problem with TortoiseHg context menu opened by right click in panel of our file manager. It has invoked unexpected commands (e.g. "View File Status" when user clicked on "Hg Workbench").

I have looked into TortoiseHg shell extension to find where is a problem. I have found that you are using global object MenuIdMap for all instances of context menu objects (CShellExtCMenu). I'm using two context menu objects for creating panel context menu and that's why this problem occurs. MenuIdMap contains IDs only for second menu and so commands from first menu are not working properly.

It seems to me that patch should be trivial, just move MenuIdMap from global space to CShellExtCMenu class. It is accessed only from methods of CShellExtCMenu. Please consider fixing this.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking