Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • thg thg
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 829
    • Issues 829
    • List
    • Boards
    • Service Desk
    • Milestones
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mercurial
  • TortoiseHg
  • thgthg
  • Issues
  • #4892
Closed
Open
Created Aug 29, 2017 by Bitbucket Importer@bitbucket_importerOwner

Unified diff output [±] button disabled when it shouldn't be

Created originally on Bitbucket by DaveInCaz (David Hollman)

I think in certain cases the unified diff output [±] button is disabled when it should be enabled.

This happens when viewing a merge changeset in the commit view.

Scenario 1:

  • File was changed with respect to parent 1, but no changes compared to parent 2

  • Click on button [1]

    • Result 1A: all three diff view option buttons are enabled
  • Click on button [2]

    • Result 1B: [±] button is disabled. Others are enabled.

Scenario 2:

  • File was changed with respect to parent 2, but no changes compared to parent 1

  • Click on button [1]

    • Result 2A: [±] button is disabled. Others are enabled.
  • Click on button [2]

    • Result 2B: [±] button is disabled. Others are enabled.

2B doesn't seem right. In that case [±] should be enabled.

Somewhat separate issue - I don't see why [±] needs to ever be disabled. If there are no differences in the comparison, it would be clearer to leave the diff view blank or show a "files are identical" message. Then this button logic would work like the other two diff options and could be simplified.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking