Unified diff output [±] button disabled when it shouldn't be
Created originally on Bitbucket by DaveInCaz (David Hollman)
I think in certain cases the unified diff output [±] button is disabled when it should be enabled.
This happens when viewing a merge changeset in the commit view.
Scenario 1:
-
File was changed with respect to parent 1, but no changes compared to parent 2
-
Click on button [1]
- Result 1A: all three diff view option buttons are enabled
-
Click on button [2]
- Result 1B: [±] button is disabled. Others are enabled.
Scenario 2:
-
File was changed with respect to parent 2, but no changes compared to parent 1
-
Click on button [1]
- Result 2A: [±] button is disabled. Others are enabled.
-
Click on button [2]
- Result 2B: [±] button is disabled. Others are enabled.
2B doesn't seem right. In that case [±] should be enabled.
Somewhat separate issue - I don't see why [±] needs to ever be disabled. If there are no differences in the comparison, it would be clearer to leave the diff view blank or show a "files are identical" message. Then this button logic would work like the other two diff options and could be simplified.