Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • thg thg
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 829
    • Issues 829
    • List
    • Boards
    • Service Desk
    • Milestones
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mercurial
  • TortoiseHg
  • thgthg
  • Issues
  • #5336
Closed
Open
Created Feb 19, 2019 by Bitbucket Importer@bitbucket_importerOwner

Bisect dialog should allow to extend the search if the culprit was a merge

Created originally on Bitbucket by jr_yworks (Johannes Rössel)

Just had to hunt a bug that was introduced way earlier than I thought and had to extend the range numerous times. This gets a bit annoying with the current Bisect dialog, as there's no way to call hg bisect --extend, nor is there a way to resume within the dialog when executing that command manually.

I've tried adding it to the source myself, but (a) my Python is way worse than most other languages I write, (b) my Qt is fairly rusty, and (c) I couldn't get the cloned repo to run a THG instance on Windows and the instructions only tell me to download a ready-made build (which I normally do, admittedly). Well, and (d), the page to create a pull request gives me a 403.

So I'm attaching the patch I made. Hopefully it works with minimal intervention. I mainly followed examples from surrounding methods, knowing nothing about any of the APIs involved. There probably might be a way to determine when bisect allows extending the range without having to read the output (which would be brittle, I guess). For now I've chosen to just enable the button when the search is done, as extend just errors when trying it when it wouldn't work.

Attachments: bisect-extend.patch

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking