Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • thg thg
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 829
    • Issues 829
    • List
    • Boards
    • Service Desk
    • Milestones
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mercurial
  • TortoiseHg
  • thgthg
  • Issues
  • #5595
Closed
Open
Created Aug 07, 2020 by teo1978@teo1978

"view change[s] in context of file" doesn't show deleted lines, nor a hint that there are any

In a repository, select a commit and select a file that has changes.

In the lower-right panel where the changes in the file are shown, most of the time I use the "+/-" diff view (called "view change in unified diff output" - I guess it should read "changes" instead of "change").

However, occasionally, I switch to the "view change[s] in context of file" view because I need to see where in the file things have been changed:

image

By having a glance at this view, I expect to find highlighted all the places where the file is modified.

However, deletions are not highlighted in any way.

If I assume that the places where the file has been changed are highlighted, I'll jump to the wrong conclusion that everywhere where there's nothing highlighted, the file is unchanged. While instead, where nothing is highlighted the file is either unchanged or lines have been deleted.

This makes this view way less useful and dangerously misleading.

I know that it is designed to show the file as it is now, with the changed parts highlighted. And I know that while you can highlight the added lines in green, and the modified lines in purple, you can't highlight deleted lines with any background color because deleted lines are no longer part of the file and hence they are not shown.

However, it would be pretty easy, and definitely necessary, to mark the places where lines have been deleted. You can do that for example with a red horizontal line (meaning a geometrical line, not a line of text), both in the text view and in the scrollbar.

Edited Aug 07, 2020 by teo1978
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking