The Tortoise Commit dialog UI workflow is poor.
Created originally on Bitbucket by Neutrino_Sunset (Neutrino Sunset)
-
Change a file.
-
In Windows Explorer right click the repository and click Commit.
-
Write your commit message in the dialog and click the Commit button.
At this point the UI you are left with makes no sense whatsoever. You have no indication whether the commit has occured successfully or not. The commit dialog is still present and the buttons 'Commit', 'Undo' and 'Cancel' are all present and enabled.
If you click Commit again, first it tells you to enter a new message and then tells you there is nothing to commit anyway. And of course you neither want to Undo nor Cancel the commit that you launched the dialog to perform in the first place.
The Cancel button appears to simply close the dialog, but there is nothing to indicate that, and the use of a Cancel button to exit a dialog that performs an operation after the operation has already taken place is both ambiguous and counter-intuitive.
The correct UI flow here is as follows:
-
You write your commit message and click the commit button.
-
You are presented with a messagebox indicating that the commit was successful
-
Clicking 'Ok' on the message box dismisses the entire Commit dialog.
Alternatively, as long as no errors have occured simply dismiss the entire Commit dialog after the Commit button is pressed.
Attachments: VersionPreCommitPostCommit