Skip to content
  • Boris Feld's avatar
    util: raise ParseError when parsing dates (BC) · bb18728ea617
    Boris Feld authored
    a7dce526c462 refactored util.parsedate in order to raise ValueError instead
    of Abort for using with ui.configwith. It causes several problems, putting
    arbitrary bytes in ValueError can cause issues with Python 3. Moreover, we
    added a function to convert ValueError exceptions back to Abort.
    
    A better approach would be to make parsedate raises ParseError, removing
    the convert function and update configwith to also catch ParseError.
    
    The side-effect is that error message when giving an invalid date in CLI
    change from:
    
      abort: invalid date: 'foo bar'
    
    to:
    
      hg: parse error: invalid date: 'foo bar'
    
    I'm not sure if it's an acceptable change, I found personally the error
    message more clear but more verbose too.
    bb18728ea617