This instance will be upgraded to Heptapod 0.21.0rc3 on 2021-04-23 at 10:30 UTC+2 (a few minutes of down time)

Commit 61303e38 authored by Jörg Sonnenberger's avatar Jörg Sonnenberger

transaction: change list of journal entries into a dictionary

The transaction object used to keep a mapping table of path names to
journal entries and a list of journal entries consisting of path and
file offset to truncate on rollback. The offsets are used in three
cases. repair.strip and rollback process all of them in one go, but they
care about the order. For them, it is perfectly reasonable to read the
journal back from disk as both operations already involve at least one
system call per journal entry. The other consumer is the revlog logic
for moving from inline to external data storage. It doesn't care about
the order of the journal and just needs to original offset stored.
Further optimisations are possible here to move the in-memory journal to
a set(), but without memoisation of the original revlog size this could
turn it into O(n^2) behavior in worst case when many revlogs need to

Differential Revision:
parent a6f08085edfe
......@@ -209,7 +209,7 @@ def strip(ui, repo, nodelist, backup=True, topic=b'backup'):
# transaction and makes assumptions that file storage is
# using append-only files. We'll need some kind of storage
# API to handle stripping for us.
offset = len(tr._entries)
oldfiles = set(tr._offsetmap.keys())
cl.strip(striprev, tr)
......@@ -219,8 +219,11 @@ def strip(ui, repo, nodelist, backup=True, topic=b'backup'):
repo.file(fn).strip(striprev, tr)
for i in pycompat.xrange(offset, len(tr._entries)):
file, troffset = tr._entries[i]
entries = tr.readjournal()
for file, troffset in entries:
if file in oldfiles:
with repo.svfs(file, b'a', checkambig=True) as fp:
if troffset == 0:
......@@ -158,8 +158,7 @@ class transaction(util.transactional):
vfsmap[b''] = opener # set default value
self._vfsmap = vfsmap
self._after = after
self._entries = []
self._map = {}
self._offsetmap = {}
self._journal = journalname
self._undoname = undoname
self._queue = []
......@@ -180,7 +179,7 @@ class transaction(util.transactional):
# a dict of arguments to be passed to hooks
self.hookargs = {}
self._file =, b"w")
self._file =, b"w+")
# a list of ('location', 'path', 'backuppath', cache) entries.
# - if 'backuppath' is empty, no file existed at backup time
......@@ -249,7 +248,7 @@ class transaction(util.transactional):
def add(self, file, offset):
"""record the state of an append-only file before update"""
if file in self._map or file in self._backupmap:
if file in self._offsetmap or file in self._backupmap:
if self._queue:
self._queue[-1].append((file, offset))
......@@ -259,10 +258,9 @@ class transaction(util.transactional):
def _addentry(self, file, offset):
"""add a append-only entry to memory and on-disk state"""
if file in self._map or file in self._backupmap:
if file in self._offsetmap or file in self._backupmap:
self._entries.append((file, offset))
self._map[file] = len(self._entries) - 1
self._offsetmap[file] = offset
# add enough data to the journal to do the truncate
self._file.write(b"%s\0%d\n" % (file, offset))
......@@ -282,7 +280,7 @@ class transaction(util.transactional):
msg = b'cannot use transaction.addbackup inside "group"'
raise error.ProgrammingError(msg)
if file in self._map or file in self._backupmap:
if file in self._offsetmap or file in self._backupmap:
vfs = self._vfsmap[location]
dirname, filename = vfs.split(file)
......@@ -396,9 +394,16 @@ class transaction(util.transactional):
def findoffset(self, file):
if file in self._map:
return self._entries[self._map[file]][1]
return None
return self._offsetmap.get(file)
def readjournal(self):
entries = []
for l in self._file:
file, troffset = l.split(b'\0')
entries.append((file, int(troffset)))
return entries
def replace(self, file, offset):
......@@ -407,10 +412,9 @@ class transaction(util.transactional):
that are not pending in the queue
if file not in self._map:
if file not in self._offsetmap:
raise KeyError(file)
index = self._map[file]
self._entries[index] = (file, offset)
self._offsetmap[file] = offset
self._file.write(b"%s\0%d\n" % (file, offset))
......@@ -550,7 +554,7 @@ class transaction(util.transactional):
b"couldn't remove %s: %s\n" % (vfs.join(b), inst)
self._entries = []
self._offsetmap = {}
if self._after:
......@@ -627,13 +631,14 @@ class transaction(util.transactional):
def _abort(self):
entries = self.readjournal()
self._count = 0
self._usages = 0
if not self._entries and not self._backupentries:
if not self._offsetmap and not self._backupentries:
if self._backupjournal:
if self._journal:
......@@ -652,7 +657,7 @@ class transaction(util.transactional):
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment