This instance will be upgraded to Heptapod 0.21.0rc3 on 2021-04-23 at 10:30 UTC+2 (a few minutes of down time)

Commit 8ab60d8b authored by Jörg Sonnenberger's avatar Jörg Sonnenberger

transaction: drop per-file extra data support

At the moment, transactions support an optional extra data argument for
all files to be stored in addition to the original offset. This is used
in core only by the revlog inline to external data migration. It is used
to memoize the number of revisions before the transaction. That number
of can be computed during the walk easily, so drop the requirement.

Differential Revision:
parent f67741e8264b
......@@ -220,7 +220,7 @@ def strip(ui, repo, nodelist, backup=True, topic=b'backup'):
for i in pycompat.xrange(offset, len(tr._entries)):
file, troffset, ignore = tr._entries[i]
file, troffset = tr._entries[i]
with repo.svfs(file, b'a', checkambig=True) as fp:
if troffset == 0:
......@@ -2005,16 +2005,9 @@ class revlog(object):
raise error.RevlogError(
_(b"%s not found in the transaction") % self.indexfile
trindex = trinfo[2]
if trindex is not None:
dataoff = self.start(trindex)
# revlog was stripped at start of transaction, use all leftover data
trindex = len(self) - 1
dataoff = self.end(tiprev)
tr.add(self.datafile, dataoff)
troffset = trinfo[1]
trindex = 0
tr.add(self.datafile, 0)
if fp:
......@@ -2026,6 +2019,8 @@ class revlog(object):
with self._indexfp(b'r') as ifh, self._datafp(b'w') as dfh:
for r in self:
dfh.write(self._getsegmentforrevs(r, r, df=ifh)[1])
if troffset <= self.start(r):
trindex = r
with self._indexfp(b'w') as fp:
self.version &= ~FLAG_INLINE_DATA
......@@ -2361,7 +2356,7 @@ class revlog(object):
offset += curr * self._io.size
transaction.add(self.indexfile, offset, curr)
transaction.add(self.indexfile, offset)
......@@ -2397,10 +2392,10 @@ class revlog(object):
ifh = self._indexfp(b"a+")
isize = r * self._io.size
if self._inline:
transaction.add(self.indexfile, end + isize, r)
transaction.add(self.indexfile, end + isize)
dfh = None
transaction.add(self.indexfile, isize, r)
transaction.add(self.indexfile, isize)
transaction.add(self.datafile, end)
dfh = self._datafp(b"a+")
......@@ -56,7 +56,7 @@ def _playback(
for f, o, _ignore in entries:
for f, o in entries:
if o or not unlink:
checkambig = checkambigfiles and (f, b'') in checkambigfiles
......@@ -243,25 +243,25 @@ class transaction(util.transactional):
This is used by strip to delay vision of strip offset. The transaction
sees either none or all of the strip actions to be done."""
q = self._queue.pop()
for f, o, data in q:
self._addentry(f, o, data)
for f, o in q:
self._addentry(f, o)
def add(self, file, offset, data=None):
def add(self, file, offset):
"""record the state of an append-only file before update"""
if file in self._map or file in self._backupmap:
if self._queue:
self._queue[-1].append((file, offset, data))
self._queue[-1].append((file, offset))
self._addentry(file, offset, data)
self._addentry(file, offset)
def _addentry(self, file, offset, data):
def _addentry(self, file, offset):
"""add a append-only entry to memory and on-disk state"""
if file in self._map or file in self._backupmap:
self._entries.append((file, offset, data))
self._entries.append((file, offset))
self._map[file] = len(self._entries) - 1
# add enough data to the journal to do the truncate
self._file.write(b"%s\0%d\n" % (file, offset))
......@@ -403,7 +403,7 @@ class transaction(util.transactional):
return None
def replace(self, file, offset, data=None):
def replace(self, file, offset):
replace can only replace already committed entries
that are not pending in the queue
......@@ -412,7 +412,7 @@ class transaction(util.transactional):
if file not in self._map:
raise KeyError(file)
index = self._map[file]
self._entries[index] = (file, offset, data)
self._entries[index] = (file, offset)
self._file.write(b"%s\0%d\n" % (file, offset))
......@@ -696,7 +696,7 @@ def rollback(opener, vfsmap, file, report, checkambigfiles=None):
for l in lines:
f, o = l.split(b'\0')
entries.append((f, int(o), None))
entries.append((f, int(o)))
except ValueError:
_(b"couldn't read journal entry %r!\n") % pycompat.bytestr(l)
......@@ -45,7 +45,7 @@ test qpush on empty series
> # Touching files truncated at "transaction.abort" causes
> # forcible re-loading invalidated filecache properties
> # (including repo.changelog)
> for f, o, _ignore in entries:
> for f, o in entries:
> if o or not unlink:
> os.utime(opener.join(f), (0.0, 0.0))
> def extsetup(ui):
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment