Commit 7a4e1d245f1 by Valentin Gatien-Baron

recover: don't verify by default

The reason is:
- it's not that hard to trigger interrupted transactions: just run out
  of disk space
- it takes forever to verify on large repos. Before --no-verify, I
  told people to C-c hg recover when the progress bar showed up. Now I
  tell them to pass --no-verify.
- I don't remember a single case where the verification step was
  useful

This is technically a change of behavior. Perhaps this would be better
suited for tweakdefaults?

Differential Revision: https://phab.mercurial-scm.org/D7972
parent 2e2cfc3bea0
......@@ -5669,7 +5669,7 @@ def push(ui, repo, dest=None, **opts):
@command(
b'recover',
[(b'', b'verify', True, b"run `hg verify` after successful recover"),],
[(b'', b'verify', False, b"run `hg verify` after successful recover"),],
helpcategory=command.CATEGORY_MAINTENANCE,
)
def recover(ui, repo, **opts):
......
......@@ -356,7 +356,7 @@ Clean cached versions
$ cat .hg/store/fncache | sort
data/y.i
data/z.i
$ hg recover
$ hg recover --verify
rolling back interrupted transaction
checking changesets
checking manifests
......
......@@ -15,11 +15,7 @@
$ hg recover
rolling back interrupted transaction
checking changesets
checking manifests
crosschecking files in changesets and manifests
checking files
checked 1 changesets with 1 changes to 1 files
(verify step skipped, run `hg verify` to check your repository content)
recover, explicit verify
......
......@@ -25,7 +25,9 @@
> else
> echo "(no journal)"
> fi
> ls .hg/store/journal >/dev/null 2>&1 && hg recover
> if ls .hg/store/journal >/dev/null 2>&1; then
> hg recover --verify
> fi
> ls .hg/strip-backup/* >/dev/null 2>&1 && hg unbundle -q .hg/strip-backup/*
> rm -rf .hg/strip-backup
> }
......
......@@ -190,7 +190,7 @@ same again, but emulate an old client that doesn't write undo.desc
corrupt journal test
$ echo "foo" > .hg/store/journal
$ hg recover
$ hg recover --verify
rolling back interrupted transaction
couldn't read journal entry 'foo\n'!
checking changesets
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment