Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openpyxl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 235
    • Issues 235
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • openpyxl
  • openpyxl
  • Merge requests
  • !138

Merged
Created Oct 19, 2016 by Bitbucket Importer@bitbucket_importerOwner

Fix #698 implements `__copy__` to create a detached copy of a `Comment`.

  • Overview 8
  • Commits 2
  • Changes 2

Created originally on Bitbucket by Tantale (Laurent LAPORTE)

Was already merged in Bitbucket before import, marked as merged by the import user

Here is a new PR based on the 2.4 branch (instead of default), to ensure .hgtags file is not modified.

To implement Cut/Copy/Paste on OpenPyXl, it it required to copy a comment (from one cell to another). This is the standard behavior in LibreOffice Calc 5.1 and Excel 2013: when you cut a cell, the comment is cutted too. When you copy a cell, the comment is copied once, then cloned the next times.

See issue 698 (details bellow):

  • Change in Comment class: the copy of a Comment now returns a detached clone (without parent Cell).

  • Minor change: remove unused import in openpyxl/comments/comments.py and re-indent code.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bitbucket/merged-pr-138