Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openpyxl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 243
    • Issues 243
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • openpyxl
  • openpyxl
  • Merge requests
  • !390

Merged
Created Jan 28, 2021 by nmartensen@nmartensenContributor

timedelta bug fix

  • Overview 5
  • Commits 4
  • Pipelines 3
  • Changes 3

(was initially the same as !389 (closed), but rebased on the 3.0 branch, and now dropped one commit)

This MR changes two minor details in the code for reading time/date values from xlsx:

  • 0 is turned into time(0,0) instead of a full datetime
  • Negative serial dates are always turned into full datetimes, never time only.

Both changes are in line with the xlsx specification. This MR makes it possible to reliably retrieve timedelta values from xlsx files using the 1904 date system, including negative timedeltas.

Edited Feb 05, 2021 by nmartensen
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: topic/3.0/timedelta