From ce59d7eee1cdfd5e77b2708a4d83ae86ef37f4ac Mon Sep 17 00:00:00 2001 From: Steve K Date: Thu, 20 May 2021 14:13:08 -0700 Subject: [PATCH] Fixes Issue 1684 - Where images are not properly closed upon insertion into a workbook. --HG-- branch : 3.0 --- openpyxl/drawing/image.py | 4 +++- openpyxl/drawing/tests/test_image.py | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/openpyxl/drawing/image.py b/openpyxl/drawing/image.py index 32bf45d8..6fd32173 100644 --- a/openpyxl/drawing/image.py +++ b/openpyxl/drawing/image.py @@ -55,7 +55,9 @@ class Image(object): img.save(fp, format="png") fp.seek(0) - return fp.read() + data = fp.read() + fp.close() + return data @property diff --git a/openpyxl/drawing/tests/test_image.py b/openpyxl/drawing/tests/test_image.py index c058d6b6..43cc7282 100644 --- a/openpyxl/drawing/tests/test_image.py +++ b/openpyxl/drawing/tests/test_image.py @@ -43,6 +43,7 @@ class TestImage: obj = PILImage.open("plain.png") img = Image(obj) assert img.ref.fp is not None + img._data() @pytest.mark.pil_required -- GitLab