Read about our upcoming Code of Conduct on this issue

Commit 6ba89c97 authored by Philip Jenvey's avatar Philip Jenvey
Browse files

issue1762 follow up: execfile should also accept null bytes

parent 2d96616d4fd6
......@@ -4,6 +4,7 @@ Plain Python definition of the builtin I/O-related functions.
import sys
from _ast import PyCF_ACCEPT_NULL_BYTES
def execfile(filename, glob=None, loc=None):
"""execfile(filename[, globals[, locals]])
......@@ -24,7 +25,8 @@ globals and locals. If only globals is given, locals defaults to it."""
#Don't exec the source directly, as this loses the filename info
co = compile(source.rstrip()+"\n", filename, 'exec')
co = compile(source.rstrip()+"\n", filename, 'exec',
exec co in glob, loc
def _write_prompt(stdout, prompt):
import sys
from rpython.tool.udir import udir
class AppTestBuiltinApp:
def setup_class(cls):
space =
class X(object):
def __eq__(self, other):
raise OverflowError
......@@ -11,18 +14,25 @@ class AppTestBuiltinApp:
except OverflowError:
cls.w_sane_lookup =
cls.w_sane_lookup = space.wrap(True)
except KeyError:
cls.w_sane_lookup =
cls.w_sane_lookup = space.wrap(False)
# starting with CPython 2.6, when the stack is almost out, we
# can get a random error, instead of just a RuntimeError.
# For example if an object x has a __getattr__, we can get
# AttributeError if attempting to call x.__getattr__ runs out
# of stack. That's annoying, so we just work around it.
if cls.runappdirect:
cls.w_safe_runtimerror =
cls.w_safe_runtimerror = space.wrap(True)
cls.w_safe_runtimerror = < (2, 6))
cls.w_safe_runtimerror = space.wrap(sys.version_info < (2, 6))
emptyfile = udir.join('')
nullbytes = udir.join('')
cls.w_emptyfile = space.wrap(str(emptyfile))
cls.w_nullbytes = space.wrap(str(nullbytes))
def test_builtin_names(self):
import __builtin__
......@@ -431,7 +441,7 @@ class AppTestBuiltinApp:
assert setattr(x, 'x', 11) == None
assert delattr(x, 'x') == None
# To make this test, we need autopath to work in application space.
#self.assertEquals(execfile(''), None)
assert execfile(self.emptyfile) == None
def test_divmod(self):
assert divmod(15,10) ==(1,5)
......@@ -611,14 +621,21 @@ def fn(): pass
assert firstlineno == 2
def test_compile_null_bytes(self):
import _ast
raises(TypeError, compile, '\x00', 'mymod', 'exec', 0)
raises(SyntaxError, compile, '\x00', 'mymod', 'exec',
src = "#abc\x00def\n"
raises(TypeError, compile, src, 'mymod', 'exec')
raises(TypeError, compile, src, 'mymod', 'exec', 0)
compile(src, 'mymod', 'exec', _ast.PyCF_ACCEPT_NULL_BYTES) # works
execfile(self.nullbytes) # works
def test_compile_null_bytes_flag(self):
from _ast import PyCF_ACCEPT_NULL_BYTES
except ImportError:
skip('PyPy only (requires _ast.PyCF_ACCEPT_NULL_BYTES)')
raises(SyntaxError, compile, '\x00', 'mymod', 'exec',
src = "#abc\x00def\n"
compile(src, 'mymod', 'exec', PyCF_ACCEPT_NULL_BYTES) # works
def test_print_function(self):
import __builtin__
......@@ -720,7 +737,6 @@ class AppTestGetattrWithGetAttributeShortcut(AppTestGetattr):
class TestInternal:
def test_execfile(self, space):
from rpython.tool.udir import udir
fn = str(udir.join('test_execfile'))
f = open(fn, 'w')
print >>f, "i=42"
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment